Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When modifying trees, devices and graphs lists ignore Autocomplete Rows setting #3613

Closed
jayaich opened this issue Jun 15, 2020 · 9 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@jayaich
Copy link
Contributor

jayaich commented Jun 15, 2020

Describe the bug

On the tree management page the 'Device Description' and 'Graph Name' columns both seem to be limited to 20 rows. We have more than 20 of both of these.
This is using Cacti 2.1.12.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Console => Management'

  2. Click on 'Trees' and select a tree to view/modify.

  3. Scroll down to '....'

  4. See error

Expected behavior

Both the device and graphs columns should be populated with all the devices and graphs.
Scroll bars should appear when the list is long.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information)

  • OS: CentOS 7

  • Browser Firefox

  • Version 77.0.1

Smartphone (please complete the following information)

  • Device: [e.g. iPhone6]

  • OS: [e.g. iOS8.1]

  • Browser [e.g. stock browser, safari]

  • Version [e.g. 22]

Additional context

I took a look at the 'tree.php' file. The '20' limits seem clear in the file. I removed them, and the device/graph columns then showed all the relevant items and scroll bars. Not sure that this is the correct fix though, so just submitted as a suggestion. Attached is a unified diff file of the changes (only 2 lines).

tree.php-diff.txt

@jayaich jayaich added bug Undesired behaviour unverified Some days we don't have a clue labels Jun 15, 2020
@cigamit cigamit added not a bug Not a bug as determined by dev and removed bug Undesired behaviour labels Jun 15, 2020
@cigamit
Copy link
Member

cigamit commented Jun 15, 2020

This is not a bug, as it is by design. It may work for removing it for your scenario, but when you have 10000 servers, it doesn't work so well. If you click on "Available Devices" or "Available Graphs" it should show a search box to allow you to filter to exactly what you are looking for.

The only change I would recommend to this, is instead changing the 20 limit to a definable setting (but still set a maximum allowed on it).

@TheWitness
Copy link
Member

The limit is configurable too. Console > Configuration > Settings > Visual > Autocomplete Rows.

@jayaich
Copy link
Contributor Author

jayaich commented Jun 15, 2020

Thanks for the replies.
We already have the autocomplete rows set to 30, but it is still not listing all our devices (24 of them).

I would agree that a configurable limit would be the best way to go. If the 'autocomplete' setting is supposed to do that, then, as said, it doesn't seem to be working for managing trees.

@TheWitness
Copy link
Member

Sounds like a bug then.

@netniV
Copy link
Member

netniV commented Jun 15, 2020

Are you able to provide screenshots? If they are sensitive in nature, please email them to developers@cacti.net

A picture can say a thousand words so I imagine several will be a novel in this case ;-)

@jayaich
Copy link
Contributor Author

jayaich commented Jun 15, 2020

Screenshot attached of the trees management page we see. We have 24 devices, and 238 graphs, but as can be seen all we get are 20 of each and no scroll bars. (Searching is possible as a solution, but I think providing a list would be preferred by the users (ours anyway!))
Screenshot_20200615_174016
.

@cigamit
Copy link
Member

cigamit commented Jun 15, 2020

@TheWitness Ya, I didn't think the autocomplete rows applied here (and it doesn't appear to) as mine is set to 10, and I have 20 in my listing also (and it appears to be hard coded to 20). We will want to fix this.

TheWitness added a commit that referenced this issue Jun 16, 2020
Tree management limited to 20 devices and graphs
@TheWitness TheWitness added this to the 1.2.13 milestone Jun 16, 2020
@TheWitness TheWitness added bug Undesired behaviour resolved A fixed issue and removed not a bug Not a bug as determined by dev unverified Some days we don't have a clue labels Jun 16, 2020
@TheWitness
Copy link
Member

Okay, you just have to update tree.php from the 1.2.x branch.

TheWitness added a commit that referenced this issue Jun 16, 2020
Resizer was throwing a recursion error in FireFox.
@jayaich
Copy link
Contributor Author

jayaich commented Jun 16, 2020

Thanks for that. The new tree.php seems to work fine.
I'll close this issue.

@jayaich jayaich closed this as completed Jun 16, 2020
@netniV netniV changed the title Tree management limited to 20 devices and graphs When modifying trees, devices and graphs lists ignore Autocomplete Rows setting Jul 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

4 participants