Disabling a Data Collector can cause unexpected errors

[DatBoiTroy]

Describe the bug

When Data Collection Enabled is unchecked under Console > Settings > Poller, undefined variable PHP errors are logged during each polling cycle until data collection is re-enabled.

To Reproduce

Steps to reproduce the behavior:

Cacti Version 1.2.12

1. Go to Console > Settings > Poller and uncheck the box for Data Collection Enabled.
2. Wait for polling cycle to pass then view the log.

Expected behavior

No PHP errors.

Error Output

020/07/06 22:00:02 - CMDPHP PHP ERROR NOTICE Backtrace: (/poller.php[801]:CactiErrorHandler())

2020/07/06 22:00:02 - ERROR PHP NOTICE: Undefined variable: hosts_per_process in file: /var/www/html/cacti/poller.php on line: 801
2020/07/06 22:00:02 - CMDPHP PHP ERROR NOTICE Backtrace: (/poller.php[800]:CactiErrorHandler())
2020/07/06 22:00:02 - ERROR PHP NOTICE: Undefined variable: method in file: /var/www/html/cacti/poller.php on line: 800

Desktop (please complete the following information)

• OS: Ubuntu 18.04 LTS
• PHP Version: 7.2

[bmfmancini]

I confirm I see the same thing

2020-07-07 09:53:01 - CMDPHP PHP ERROR NOTICE Backtrace: (/poller.php[797]:CactiErrorHandler())
2020-07-07 09:53:01 - ERROR PHP NOTICE: Undefined variable: hosts_per_process in file: /var/www/html/cacti/poller.php on line: 797
2020-07-07 09:53:01 - CMDPHP PHP ERROR NOTICE Backtrace: (/poller.php[796]:CactiErrorHandler())
2020-07-07 09:53:01 - ERROR PHP NOTICE: Undefined variable: method in file: /var/www/html/cacti/poller.php on line: 796