Skip to content

When Input Field is in error, message reports field will be highlighted which is incorrect #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavidLiedke opened this issue Jul 8, 2020 · 1 comment · Fixed by #3680
Closed

When Input Field is in error, message reports field will be highlighted which is incorrect #3668

DavidLiedke opened this issue Jul 8, 2020 · 1 comment · Fixed by #3680
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
1.2.13

Comments

@DavidLiedke
Copy link
Contributor

Describe the bug

Cacti Version 1.2.12

Error Message: Save Failed due to field input errors (Check red fields).

The error message says that the field is marked red. But the field: "Input Field" is not marked red.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Data Collection --> Data Input Method

  2. Select one Input Method

  3. Add one Input Field

  4. Dont select a field and click "Create"

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

ABiEBovc7S

Desktop (please complete the following information)

  • OS: [e.g. iOS] Win 10

  • Browser [e.g. chrome, safari] Firefox

  • Version [e.g. 22] 78.0.1

Smartphone (please complete the following information)

  • Device: [e.g. iPhone6]

  • OS: [e.g. iOS8.1]

  • Browser [e.g. stock browser, safari]

  • Version [e.g. 22]

Additional context

Add any other context about the problem here.
@DavidLiedke DavidLiedke added bug Undesired behaviour unverified Some days we don't have a clue labels Jul 8, 2020
@TheWitness TheWitness changed the title [1.2.12] "Input Field" is not marked red after error message "Input Field" is not marked red after error message Jul 11, 2020
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Jul 11, 2020
@TheWitness TheWitness linked a pull request Jul 11, 2020 that will close this issue
Fixing Issues #3663, #3655, #3651, #3681, #3668, #3669 #3680
Merged
@TheWitness TheWitness added this to the 1.2.13 milestone Jul 11, 2020
@TheWitness
Copy link
Member

David, took a slightly different approach here. But this issue should not happen again.

netniV pushed a commit that referenced this issue Jul 11, 2020
@TheWitness
Fixing Issues #3663, #3655, #3651, #3681, #3668, #3669 (#3680)
a8e43b1
@netniV netniV changed the title "Input Field" is not marked red after error message When Input Field is in error, message reports field will be highlighted which is incorrect Jul 12, 2020
@netniV netniV closed this as completed Jul 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
1.2.13
Development

Successfully merging a pull request may close this issue.

Fixing Issues #3663, #3655, #3651, #3681, #3668, #3669
3 participants
@TheWitness @netniV @DavidLiedke