Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate deleted device status instead of poller sync #3741

Closed
bmfmancini opened this issue Aug 5, 2020 · 10 comments
Closed

Replicate deleted device status instead of poller sync #3741

bmfmancini opened this issue Aug 5, 2020 · 10 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@bmfmancini
Copy link
Member

Hey Guys!

Currently in a multi poller setup when you delete a device that device will hang around until full poller sync is done
I have my poller sync disabled I manually do it for big changes or auth changes etc

It would be nice and helpful if when a device is deleted that the change is pushed so that the device deletes without a poller sync

Thanks!

@bmfmancini bmfmancini added the enhancement General tag for an enhancement label Aug 5, 2020
@TheWitness
Copy link
Member

This seems more to be a bug.

@TheWitness TheWitness added bug Undesired behaviour and removed enhancement General tag for an enhancement labels Oct 19, 2020
@bmfmancini
Copy link
Member Author

Good to know I thought it was by design but yea maybe would make sense to be a bug
I have noticed it since 1.2.7

@TheWitness
Copy link
Member

This is interesting, the 1.2.15 code should be removing those entries. My guess is that a mostly blank host entry is coming back as you are likely deleting the entry while the poller is running, and it's being added back again due to an update. I won't be able to fix this today, might need a day to re-verify the code, as it's supposed to have a delay.

@bmfmancini
Copy link
Member Author

bmfmancini commented Oct 19, 2020 via email

@TheWitness
Copy link
Member

I've looked over the code, we wait 500 seconds before removing taking a second shot at removing the remote device. As far as I can tell, this is working as expected. The only case where this will break is when the Cacti attempts to perform the purge, and the remote data collector can not be reached, in which case, you only option will be a full sync, which I have recently made a little less intrusive. So, let's just stick with that.

@TheWitness TheWitness added not a bug Not a bug as determined by dev and removed bug Undesired behaviour labels Oct 24, 2020
@bmfmancini
Copy link
Member Author

bmfmancini commented Oct 24, 2020 via email

@TheWitness
Copy link
Member

If you are around today, we could do a WebEx, Zoom whatever. Just ping to the ticket. I'll be online most of the day.

@bmfmancini
Copy link
Member Author

bmfmancini commented Oct 25, 2020 via email

@TheWitness
Copy link
Member

Send an email to my cacti account with your mobile. I'll buzz you on Monday. Have to do it at lunch or evenings if we do it during the week.

@bmfmancini
Copy link
Member Author

bmfmancini commented Oct 26, 2020

Hey @TheWitness I will send over my contact shortly
I think I have narrowed down what the issue is atleast in my mind

when you delete a device check the main pollers db the last_updated time stamp always updates even on the device that has been deleted until you sync the pollers then it stops then after a few minutes the entries are purged

@TheWitness TheWitness changed the title [Feature Request] Replicate deleted device status instead of poller sync Replicate deleted device status instead of poller sync Oct 28, 2020
@TheWitness TheWitness added bug Undesired behaviour and removed not a bug Not a bug as determined by dev labels Oct 28, 2020
@TheWitness TheWitness reopened this Oct 28, 2020
TheWitness added a commit that referenced this issue Oct 28, 2020
Replicate deleted device status instead of poller sync
TheWitness added a commit that referenced this issue Oct 28, 2020
Implemented the function change but did not call it from the multi-function
TheWitness added a commit that referenced this issue Oct 28, 2020
TheWitness added a commit that referenced this issue Oct 28, 2020
@TheWitness TheWitness added the resolved A fixed issue label Oct 28, 2020
@TheWitness TheWitness added this to the 1.2.15 milestone Oct 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants