Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installing or upgrading, LDAP functions may not always be included properly #3747

Closed
browniebraun opened this issue Aug 11, 2020 · 5 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@browniebraun
Copy link
Member

Only happening while the installer is running, because in this case the current working directory is /install/.
Introduced by the changing the path from

include_once(__DIR__ . '/lib/ldap.php');

to

/* include ldap support */
include_once('./lib/ldap.php');
@browniebraun browniebraun added bug Undesired behaviour unverified Some days we don't have a clue labels Aug 11, 2020
@browniebraun browniebraun added this to the 1.2.15 milestone Aug 11, 2020
@netniV
Copy link
Member

netniV commented Aug 11, 2020

This is one of four things I sent myself to fix last night but I didn't get to it. Saved me opening the issue.

I fixed this on my work network

@netniV
Copy link
Member

netniV commented Aug 11, 2020

Also it looks like @cigamit also patched this yesterday so funny that there are three of us on the same page.

@browniebraun
Copy link
Member Author

lol - I'm back from vacay ;)

@TheWitness
Copy link
Member

Is this all resolved then?

TheWitness added a commit that referenced this issue Aug 26, 2020
ldap.php cannot be loaded while installer is runnin
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Aug 26, 2020
@eschoeller
Copy link

I also got hit by this bug on an upgrade to 1.2.14. Glad it was already worked out:)

@netniV netniV changed the title ldap.php cannot be loaded while installer is running. When installing or upgrading, LDAP functions may not always be included properly Nov 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

4 participants