Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Data Queries with multiple data templates can give errors about Suggested values #3764

Closed
georgetasioulis opened this issue Aug 19, 2020 · 4 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@georgetasioulis
Copy link

On a Data Query with more than one pair (in/out) of data sources, for example when monitoring traffic and unicast packets in a single graph, adding suggested values for the second set of data sources throws an error:

Suggested Value was not entered. Please enter a suggested value and try again.

To Reproduce

Steps to reproduce the behavior:

On a data query with at least two data templates (ie traffic and unicast packets) add a field name and suggested value for the second data template.

Expected behavior

Being able to add suggested values for the second data template

Screenshots

GIF1

Desktop

  • OS: MacOS Catalina
  • Browser: Chrome
  • Version: 84.0.4147.125

Cacti

  • Version: 1.2.13
@georgetasioulis georgetasioulis added bug Undesired behaviour unverified Some days we don't have a clue labels Aug 19, 2020
@TheWitness
Copy link
Member

Oh, that's interesting. I've never really tried that before. Wondering if you can really create graph's that way. Have you confirmed that it otherwise workse?

@TheWitness
Copy link
Member

Just looked at the code. Taking a look at it.

@TheWitness
Copy link
Member

Old nasty code. Glad it's fixed.

TheWitness added a commit that referenced this issue Aug 30, 2020
Suggested values on Data Queries with multiple data templates gives error
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Aug 30, 2020
@TheWitness TheWitness added this to the 1.2.15 milestone Aug 30, 2020
@TheWitness
Copy link
Member

Okay, this is fixed in the 1.2.x branch.

@netniV netniV changed the title Suggested values on Data Queries with multiple data templates gives error Editing Data Queries with multiple data templates can give errors about Suggested values Nov 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants