Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters do not always respect using keyboard to initiate searching #3775

Closed
barreljan opened this issue Aug 28, 2020 · 3 comments
Closed

Filters do not always respect using keyboard to initiate searching #3775

barreljan opened this issue Aug 28, 2020 · 3 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@barreljan
Copy link
Contributor

barreljan commented Aug 28, 2020

Describe the bug

When you log in to Cacti, and go in the three mode and click on any device, then search a specific string it all works fine. If you open the console, hit for instance the Management and Graphs button, return to the Graphs (top tab) and do a search in the same host, again with the same in the search field and hitting 'enter' you end up with the page from console. If you click on the Go button this behavior is not observed.

To Reproduce

Steps to reproduce the behavior:

  1. Go to tab Graphs

  2. Click on a host in the tree

  3. Enter a string in the search field en hit 'enter' (do not click on go)

  4. Go to tab Console

  5. Click on Management and then Graphs (or any item, e.g. System Utilities and the View User Log)

  6. Go to tab Graphs

  7. Enter a string in the seach field and hit 'enter' (do not click on go)

  8. Page of the last visited item under tab Console shows up

Expected behavior

When hitting enter, just as clicking on the Go button, a list of graphs matching the search string.

  • OS: Windows 10

  • Browser: Edge Chromium, FireFox, IE11

  • Cacti Version: 1.2.14

  • Server running Centos7 (latest updates). Apache 2.4, PHP 7.4.9

Workaround for now:
Log out, log back in, search again. Any time you click on something within the Console tab, you end up with this. Unless you hit the Go button of course.

@barreljan barreljan added bug Undesired behaviour unverified Some days we don't have a clue labels Aug 28, 2020
@TheWitness
Copy link
Member

Thanks for logging this. This has been an annoyance for some time. Makes sense to make a light modification.

@TheWitness
Copy link
Member

Interesting. Have not tested in a while, and I'm getting this too. Seems my database default collation is not right.

image

@TheWitness
Copy link
Member

Testing after this:

alter database cacti collate utf8mb4_unicode_ci character set utf8mb4;

TheWitness added a commit that referenced this issue Aug 30, 2020
* Need to redefine the applyFilter as it's still defined for the 'go' action on the graphs page.
* The base64_encode in layout.js does not encode properly for in all cases
* Prevent the validate function from being called twice on a full page refresh
* Add the rfilter to timespan actions just in case the user has set it and not hit enter to filter
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Aug 30, 2020
@TheWitness TheWitness added this to the 1.2.15 milestone Aug 30, 2020
@netniV netniV changed the title Search field strange behavior when hitting enter in 1.2.14 Filters do not always respect using keyboard to initiate searching Nov 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants