Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation can sometimes occur unexpectedly due to background timers #3849

Closed
zuka1337 opened this issue Oct 7, 2020 · 10 comments
Closed

Navigation can sometimes occur unexpectedly due to background timers #3849

zuka1337 opened this issue Oct 7, 2020 · 10 comments
Labels
bug Undesired behaviour resolved A fixed issue

Comments

@zuka1337
Copy link

zuka1337 commented Oct 7, 2020

Describe the bug

Somethimes when I search for an graph on the tree view it redrects me to the graph management on the same page

A clear and concise description of what the bug is.

To Reproduce

For me I add hosts from network devices add the graphs as you need add to a specifc tree.

Sorry if this behavior is normal..

I'm posting later the tree and host management pages on tree view
Image Graph Mgt
cacti_tree

Image Host mgt:
cacti_host

Logs:

2020-10-07 18:06:40 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[252]:draw_edit_form(), /lib/html_form.php[114]:draw_edit_control(), /lib/html_form.php[463]:CactiErrorHandler())
--
2020-10-07 18:06:40 - ERROR PHP NOTICE: Undefined index: value in file: /cacti/lib/html_form.php  on line: 463
2020-10-07 18:06:40 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[252]:draw_edit_form(), /lib/html_form.php[114]:draw_edit_control(), /lib/html_form.php[461]:CactiErrorHandler())
2020-10-07 18:06:40 - ERROR PHP NOTICE: Undefined index: value in file: /cacti/lib/html_form.php  on line: 461
2020-10-07 18:06:40 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[181]:CactiErrorHandler())
2020-10-07 18:06:40 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php  on line: 181
2020-10-07 18:06:40 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[180]:CactiErrorHandler())
2020-10-07 18:06:40 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php  on line: 180
2020-10-07 18:05:03 - SYSTEM DSDEBUG STATS: Type:poller, ChecksPerformed:1, TotalIssues:0, Time:0.0215
2020-10-07 18:05:03 - SYSTEM STATS: Time:1.2218 Method:spine Processes:1 Threads:1 Hosts:7 HostsPerProcess:7 DataSources:41 RRDsProcessed:0
2020-10-07 18:03:44 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[252]:draw_edit_form(), /lib/html_form.php[114]:draw_edit_control(), /lib/html_form.php[463]:CactiErrorHandler())
2020-10-07 18:03:44 - ERROR PHP NOTICE: Undefined index: value in file: /cacti/lib/html_form.php  on line: 463
2020-10-07 18:03:44 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[252]:draw_edit_form(), /lib/html_form.php[114]:draw_edit_control(), /lib/html_form.php[461]:CactiErrorHandler())
2020-10-07 18:03:44 - ERROR PHP NOTICE: Undefined index: value in file: /cacti/lib/html_form.php  on line: 461
2020-10-07 18:03:44 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[181]:CactiErrorHandler())
2020-10-07 18:03:44 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php  on line: 181
2020-10-07 18:03:44 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[180]:CactiErrorHandler())
2020-10-07 18:03:44 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php  on line: 180
2020-10-07 18:03:28 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[252]:draw_edit_form(), /lib/html_form.php[114]:draw_edit_control(), /lib/html_form.php[463]:CactiErrorHandler())
2020-10-07 18:03:28 - ERROR PHP NOTICE: Undefined index: value in file: /cacti/lib/html_form.php  on line: 463
2020-10-07 18:03:28 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[252]:draw_edit_form(), /lib/html_form.php[114]:draw_edit_control(), /lib/html_form.php[461]:CactiErrorHandler())
2020-10-07 18:03:28 - ERROR PHP NOTICE: Undefined index: value in file: /cacti/lib/html_form.php  on line: 461
2020-10-07 18:03:28 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[181]:CactiErrorHandler())
2020-10-07 18:03:28 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php  on line: 181
2020-10-07 18:03:28 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs.php[116]:graph_edit(), /graphs.php[1576]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[180]:CactiErrorHandler())
2020-10-07 18:03:28 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php  on line: 180
2020-10-07 18:01:50 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs_new.php[41]:form_save(), /graphs_new.php[149]:html_graph_new_graphs(), /lib/html_graph.php[434]:html_graph_custom_data(), /lib/html_graph.php[547]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[181]:CactiErrorHandler())
2020-10-07 18:01:50 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php  on line: 181
2020-10-07 18:01:50 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graphs_new.php[41]:form_save(), /graphs_new.php[149]:html_graph_new_graphs(), /lib/html_graph.php[434]:html_graph_custom_data(), /lib/html_graph.php[547]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[180]:CactiErrorHandler())
2020-10-07 18:01:50 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php  on line: 180

@zuka1337 zuka1337 added bug Undesired behaviour unverified Some days we don't have a clue labels Oct 7, 2020
@TheWitness
Copy link
Member

You fail to mention your current cacti version.

@zuka1337
Copy link
Author

zuka1337 commented Oct 8, 2020

Well, you're right, I'm sorry about that..

Version: 1.2.14
Browser: Chrome, IE, Firefox
Fresh and new Installation and Database

@TheWitness
Copy link
Member

Thanks. This really is suspicious like a plugin. However, I've updated lib/html_form.php and include/layout.js in the 1.2.x branch. If you update those two files, does this problem go away?

@TheWitness TheWitness removed the unverified Some days we don't have a clue label Oct 9, 2020
TheWitness added a commit that referenced this issue Oct 9, 2020
Graph Tree - Redirect to host/tree/Graph Management
@TheWitness TheWitness added the resolved A fixed issue label Oct 9, 2020
@zuka1337
Copy link
Author

zuka1337 commented Oct 9, 2020

Thank you, I'm going to test it later today !

@zuka1337
Copy link
Author

zuka1337 commented Oct 15, 2020

It worked very well ! But no I have other issue:
Instead of openning an new Issue here we go:

The tree does not load graph_view
The graph_tree goes blank and get the error below:

2020-10-15 14:57:24 - CMDPHP PHP ERROR NOTICE Backtrace: (/graph_view.php[221]:top_graph_header(), /lib/functions.php[3287]:include_once(), /include/top_graph_header.php[55]:grow_dhtml_trees(), /lib/html_tree.php[142]:get_tree_path(), /lib/html_tree.php[443]:CactiErrorHandler())
--
2020-10-15 14:57:24 - ERROR PHP NOTICE: Undefined index: parent in file: /cacti/lib/html_tree.php on line: 443

Version 1.2.14
Version 1.2.7
Fresh install with device imported from automation.

@zuka1337
Copy link
Author

zuka1337 commented Oct 15, 2020

And now I got this one..


2020-10-15 15:48:33 - CMDPHP PHP ERROR NOTICE Backtrace: (/graphs_new.php[41]:form_save(), /graphs_new.php[149]:html_graph_new_graphs(), /lib/html_graph.php[434]:html_graph_custom_data(), /lib/html_graph.php[547]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[181]:CactiErrorHandler())
--
2020-10-15 15:48:33 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php on line: 181
2020-10-15 15:48:33 - CMDPHP PHP ERROR NOTICE Backtrace: (/graphs_new.php[41]:form_save(), /graphs_new.php[149]:html_graph_new_graphs(), /lib/html_graph.php[434]:html_graph_custom_data(), /lib/html_graph.php[547]:draw_nontemplated_fields_graph_item(), /lib/html_form_template.php[180]:CactiErrorHandler())
2020-10-15 15:48:33 - ERROR PHP NOTICE: Undefined index: task_item_id in file: /cacti/lib/html_form_template.php on line: 180


Version 1.2.14
Fresh install with device imported from automation.

@TheWitness
Copy link
Member

The second issue has already been address. Please use the 1.2.x branch and report back.

@TheWitness
Copy link
Member

Interesting how the first issue has not seen before now.

@TheWitness
Copy link
Member

I'll create a separate issue for the new issues. Second issue already addressed.

@zuka1337
Copy link
Author

Thanks, you're a machine !

@netniV netniV changed the title Graph Tree - Redirect to host/tree/Graph Management Navigation can sometimes occur unexpectedly due to background timers Nov 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants