When importing a data query, an invalid column name error can sometimes be shown

[MarcBanyard]

Describe the bug

Import DataQuery show PHP Error: ERROR PHP NOTICE: Undefined index: fname in file: /var/www/cacti/lib/import.php on line: 1798
CMDPHP PHP ERROR NOTICE Backtrace: (/templates_import.php[43]:form_save(), /templates_import.php[97]:import_xml_data(), /lib/import.php[194]:xml_to_data_input_method(), /lib/import.php[1743]:compare_data(), /lib/import.php[1798]:CactiErrorHandler())

To Reproduce

Steps to reproduce the behavior:

1. Go to Console->Import/Export-->Import Templates

2. Click "Select a File" and choose the file you want to import that contains a Data Query

3. Disable "Preview Import Only"

4. Click "Import"

5. See onscreen popup error

6. Check "Logs" tab, this should contain something like the following

DBCALL ERROR: SQL Save on table 'data_input_fields': Column 'fname' does not exist, unable to save!
CMDPHP PHP ERROR NOTICE Backtrace: (/templates_import.php[43]:form_save(), /templates_import.php[97]:import_xml_data(), /lib/import.php[194]:xml_to_data_input_method(), /lib/import.php[1743]:compare_data(), /lib/import.php[1798]:CactiErrorHandler())
ERROR PHP NOTICE: Undefined index: fname in file: /var/www/cacti/lib/import.php on line: 1798

7. See Error

Additional context

This looks like it is related to issue #3778.

[MarcBanyard]

This only happens on a Device Template import that contains a Data Query.

[TheWitness]

This is already fixed in the 1.2.x branch and will be a part of the 1.2.15 release.

[MarcBanyard]

I've just tested on the 1.2.x branch and its not working.
It only happens if you have a device template that contains a Data Query.

[TheWitness]

Oh, I see now. Take just a few minutes to fix.

[MarcBanyard]

We are running v1.2.15 and the error comes up as

This ONLY happens when importing a Device Template that contains a Data Query.

I have even tried to remove the Data Query from the bottom of the XML and the error still happens, so it is only referenced in the top part of the XML.

[TheWitness]

grab lib/import.php and try again.

[MarcBanyard]

Still the same error I'm afraid

[TheWitness]

Try again.

[MarcBanyard]

Perfect, that has fixed the error, wow that was a quick fix.

[TheWitness]

It's Lunch time ;)

[MarcBanyard]

How far off is 1.2.15 from being released as the latest version?
This is the only issue we have come across so far with it so far.

[TheWitness]

Well, the more testing done by people like you, the closer it is. We are now a month behind, and I keep saying no more, a day before more show up.