Repository navigation
When importing a data query, an invalid column name error can sometimes be shown #3871
Description
Describe the bug
Import DataQuery show PHP Error: ERROR PHP NOTICE: Undefined index: fname in file: /var/www/cacti/lib/import.php on line: 1798
CMDPHP PHP ERROR NOTICE Backtrace: (/templates_import.php[43]:form_save(), /templates_import.php[97]:import_xml_data(), /lib/import.php[194]:xml_to_data_input_method(), /lib/import.php[1743]:compare_data(), /lib/import.php[1798]:CactiErrorHandler())
To Reproduce
Steps to reproduce the behavior:
-
Go to Console->Import/Export-->Import Templates
-
Click "Select a File" and choose the file you want to import that contains a Data Query
-
Disable "Preview Import Only"
-
Click "Import"
-
See onscreen popup error
-
Check "Logs" tab, this should contain something like the following
DBCALL ERROR: SQL Save on table 'data_input_fields': Column 'fname' does not exist, unable to save!
CMDPHP PHP ERROR NOTICE Backtrace: (/templates_import.php[43]:form_save(), /templates_import.php[97]:import_xml_data(), /lib/import.php[194]:xml_to_data_input_method(), /lib/import.php[1743]:compare_data(), /lib/import.php[1798]:CactiErrorHandler())
ERROR PHP NOTICE: Undefined index: fname in file: /var/www/cacti/lib/import.php on line: 1798
- See Error
Additional context
This looks like it is related to issue #3778.
Activity
MarcBanyard commentedon Oct 19, 2020
This only happens on a Device Template import that contains a Data Query.
TheWitness commentedon Oct 19, 2020
This is already fixed in the 1.2.x branch and will be a part of the 1.2.15 release.
MarcBanyard commentedon Oct 19, 2020
I've just tested on the 1.2.x branch and its not working.
It only happens if you have a device template that contains a Data Query.
TheWitness commentedon Oct 19, 2020
Oh, I see now. Take just a few minutes to fix.
MarcBanyard commentedon Oct 19, 2020
We are running v1.2.15 and the error comes up as
This ONLY happens when importing a Device Template that contains a Data Query.
I have even tried to remove the Data Query from the bottom of the XML and the error still happens, so it is only referenced in the top part of the XML.
Fixing Issue #3871
TheWitness commentedon Oct 19, 2020
grab lib/import.php and try again.
MarcBanyard commentedon Oct 19, 2020
Still the same error I'm afraid
Second attempt at issue #3871
TheWitness commentedon Oct 19, 2020
Try again.
MarcBanyard commentedon Oct 19, 2020
Perfect, that has fixed the error, wow that was a quick fix.
TheWitness commentedon Oct 19, 2020
It's Lunch time ;)
MarcBanyard commentedon Oct 19, 2020
How far off is 1.2.15 from being released as the latest version?
This is the only issue we have come across so far with it so far.
TheWitness commentedon Oct 19, 2020
Well, the more testing done by people like you, the closer it is. We are now a month behind, and I keep saying no more, a day before more show up.
[-]Import DataQuery show PHP Error: ERROR PHP NOTICE: Undefined index: fname[/-][+]When importing a data query, an invalid column name error can sometimes be shown[/+]