Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cli-based installer does not exit with a non-zero exit code when error occurs #3907

Closed
TheWitness opened this issue Nov 6, 2020 · 1 comment
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug

When errors occur in the install_cacti.php script, the script should exit with a non-zero exit code, which it does not.

To Reproduce

Steps to reproduce the behavior:

  1. Go to /var/www/html/cacti/cli

  2. uninstall a critical php module such as ldap

  3. Run the installer to install cacti. Not that there are errors

  4. Run "echo $?" and note that the scripted exited with a zero error code

Expected behavior

CLI script should exit with non-zero exit codes when they fail.

@TheWitness TheWitness added bug Undesired behaviour resolved A fixed issue labels Nov 6, 2020
@netniV
Copy link
Member

netniV commented Nov 6, 2020

No commit was assigned this tracker?

@TheWitness TheWitness added this to the v1.2.16 milestone Nov 10, 2020
@netniV netniV changed the title The cli script install_cacti.php does not exit with not zero exit code when error occur The cli-based installer does not exit with a non-zero exit code when error occurs Nov 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants