Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username and password on the login page is not visible in Classic theme #3926

Closed
RadekHvizdos opened this issue Nov 19, 2020 · 14 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@RadekHvizdos
Copy link

Describe the bug

When I type a username and password for login to Cacti I don't see typed characters in Classic theme. On some browser/OS combinations the placeholder text for Username and Password is also not visible.

I think a character's color is equal to background color.

This is a similar bug to #3535

To Reproduce

Steps to reproduce the behavior:

  1. Switch to Classic Theme

  2. Logout

  3. Try to login

Expected behavior

I should be able to see the placeholder text and what I am typing into the input fields.

Screenshots

cacti_login

Desktop (please complete the following information)

  • OS: Windows 10

  • Browser: Brave, Firefox, Internet Explorer (yuk!)

  • Version: latest

Smartphone (please complete the following information)

  • OS: Android 10

  • Browser: Brave, Firefox

  • Version: latest

Additional context

I can fix the issue by editing the theme file and adding "color: black" here:

# cat /usr/share/cacti/site/include/themes/classic/main.css.fix
.ui-state-default {
        background: #FFFFFF !important;
        border: none;
        font-weight: normal;
        padding: 2px;
        color: black;
}

But this is probably not the correct solution.

@RadekHvizdos RadekHvizdos added bug Undesired behaviour unverified Some days we don't have a clue labels Nov 19, 2020
@TheWitness
Copy link
Member

Thanks for pointing this out. Classic is like a burr in my saddle, but so many people love that tombstone theme.

@xmacan
Copy link
Member

xmacan commented Nov 20, 2020

@TheWitness What is wrong on classic theme? I prefere Paw, classic and maybe modern. The others are confusing and ugly (for me). I switch to paw because classic has few bugs. I thought about new Classic+ or fix Classic

TheWitness added a commit that referenced this issue Nov 20, 2020
Username and password on the login page is not visible in Classic theme
@TheWitness TheWitness added this to the v1.2.16 milestone Nov 20, 2020
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Nov 20, 2020
@TheWitness
Copy link
Member

@xmacan, after 18 years.... Nothing is technically wrong with it, but after all that time looking at the same canvas, It'll drive you insane. Too late for me :)

@TheWitness
Copy link
Member

Close enough I hope.

image

@TheWitness
Copy link
Member

Hmm, I copied and pasted and it turned green. Let me check that color.

TheWitness added a commit that referenced this issue Nov 20, 2020
Shouldn't have been green.
@TheWitness
Copy link
Member

Okay, I think it should look better now. Though I like your button color, going to defer due to "Classic". You can fix by "cp -rp classic mytheme".

@TheWitness TheWitness changed the title Username and password on the login page is not visible in Classic theme (again) Username and password on the login page is not visible in Classic theme Nov 20, 2020
@RadekHvizdos
Copy link
Author

Neither changes take any effect in my setup, the input fields do not show the hints or characters I type :(

@TheWitness
Copy link
Member

Yea, the browsers are being a pain these days. You have to force a refresh of the CSS even after we hacked and hacked to try to out think them. After your cache is cleared, it'll look like as below (FF).

image

@RadekHvizdos
Copy link
Author

I have tested the following scenarios:

Brave and Edge show the hints (not the login credentials), but Internet Explorer and Firefox show neither. I have cleared the browser caches multiple times.

Tested on Android and Windows 10.

@TheWitness
Copy link
Member

This is IE11 and the current Classic on 1.2.16.

image

@RadekHvizdos
Copy link
Author

This is so strange. I have tested this:

PC1 W10, AMD GPU:

pc1

PC2 W10 Intel GPU:

pc2

I have no idea why it works for you and not for me :(

@RadekHvizdos
Copy link
Author

I should probably also mention that I have another Cacti installation (same version) which exhibits the same behavior. The installations were done on different dates, upgraded to latest version provided by Debian.

@TheWitness
Copy link
Member

Oh, lol, the input text. Let me test that too.

@TheWitness
Copy link
Member

Latest firefox, but not the color of the button, you have some other CSS interfering with the classic theme. I think if you trace that, you will find your issue. I'll go ahead and close now, and thanks for pointing out original the issue.

image

@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants