Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a graph created from Aggregate Graph can fail #3936

Closed
iskandarbasman opened this issue Nov 23, 2020 · 8 comments
Closed

Editing a graph created from Aggregate Graph can fail #3936

iskandarbasman opened this issue Nov 23, 2020 · 8 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@iskandarbasman
Copy link

Hi @TheWitness,
Can we revisit this bug, it still happens till now on the developer cacti.

Please refer to #3651 for the original report of the bug.

I uploaded a youtube video on my test cacti on how to reproduce it.
https://youtu.be/lvL6lF3a8Ig

@iskandarbasman iskandarbasman added bug Undesired behaviour unverified Some days we don't have a clue labels Nov 23, 2020
@TheWitness
Copy link
Member

The reason that this graph broke, is that you selected that you wanted to aggregate similar items, but you did not pick a Data Source for it to compare against. So, the behavior you got is kind of how this thing works. I guess that we could disable the save button if you pick that specific CDEF and have not selected a Data Source. That would be an acceptable workaround.

TheWitness added a commit that referenced this issue Jan 1, 2021
Aggregate Graph that has been converted to a normal graph breaks when edited
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Jan 1, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Jan 1, 2021
@TheWitness
Copy link
Member

Okay, I corrected the behavior sufficiently for the moment.

@iskandarbasman
Copy link
Author

iskandarbasman commented Jan 10, 2021

@TheWitness , uhhh trying to test with the current version of cacti 1.2.x but running into major problems with my test cacti.
Looks pretty broken and the legend is messed up and even all the graph view options icons are gone.

image

image

image

image

@TheWitness
Copy link
Member

TheWitness commented Jan 10, 2021

You need to upload a screen2gif starting with a working aggregate showing what actions cause it to break.

@iskandarbasman
Copy link
Author

@TheWitness

Just to clarify the issue is not limited to aggregates, all graph legends are broken.
I could rollback to the previous version later.

image

@TheWitness
Copy link
Member

Okay, I backed out the offending change in the 1.2.x branch. You will have to test again using the updated data. There is just one change to one file. Have to do some research on the exploit vector to correct for it in a less obstructive way.

@iskandarbasman
Copy link
Author

@TheWitness

Doing a quick test.

What I observer currently.
There broken legends are fixed but seems all the graph tool icons are still missing.
image

For the original bug editing the convert normal graph still breaks aggregate.
Will a capture of it.. I need to understand the work around you are suggesting though.

@TheWitness
Copy link
Member

You have to give yourself that permission in 1.2.17+

@netniV netniV changed the title Aggregate Graph that has been converted to a normal graph breaks when edited Editing a graph created from Aggregate Graph can fail Apr 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants