Editing a graph created from Aggregate Graph can fail

[iskandarbasman]

Hi @TheWitness,
Can we revisit this bug, it still happens till now on the developer cacti.

Please refer to #3651 for the original report of the bug.

I uploaded a youtube video on my test cacti on how to reproduce it.
https://youtu.be/lvL6lF3a8Ig

[TheWitness]

The reason that this graph broke, is that you selected that you wanted to aggregate similar items, but you did not pick a Data Source for it to compare against. So, the behavior you got is kind of how this thing works. I guess that we could disable the save button if you pick that specific CDEF and have not selected a Data Source. That would be an acceptable workaround.

[TheWitness]

Okay, I corrected the behavior sufficiently for the moment.

[iskandarbasman]

@TheWitness , uhhh trying to test with the current version of cacti 1.2.x but running into major problems with my test cacti.
Looks pretty broken and the legend is messed up and even all the graph view options icons are gone.

[TheWitness]

You need to upload a screen2gif starting with a working aggregate showing what actions cause it to break.

[iskandarbasman]

@TheWitness

Just to clarify the issue is not limited to aggregates, all graph legends are broken.
I could rollback to the previous version later.

[TheWitness]

Okay, I backed out the offending change in the 1.2.x branch. You will have to test again using the updated data. There is just one change to one file. Have to do some research on the exploit vector to correct for it in a less obstructive way.

[iskandarbasman]

@TheWitness

Doing a quick test.

What I observer currently.
There broken legends are fixed but seems all the graph tool icons are still missing.

For the original bug editing the convert normal graph still breaks aggregate.
Will a capture of it.. I need to understand the work around you are suggesting though.

[TheWitness]

You have to give yourself that permission in 1.2.17+