Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks for plugins to show custom Graph Source and custom Template URL (List View) #3943

Closed
YongBoLiu opened this issue Nov 24, 2020 · 1 comment
Labels
enhancement General tag for an enhancement resolved A fixed issue
Milestone

Comments

@YongBoLiu
Copy link
Contributor

Feature Request

Yes, after auto created huge number of graphs without graph template in my plugin, it shows 'Not Templated' in both 'Source Type' and 'Source name' fields. In Graphs->List View.

We need to provide hooks to customize the 'Source Type' and 'Source name' fields for plugins. Because these graphs without graph template can have some special property for plugin.

A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]
If no hooks for this, plugin develop have to update the graphs.php again and again after cacti core upgraded.

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've
considered.

Additional context

Add any other context or screenshots about the feature request here.
The same hooks needed as we did in In Console->Management->Graphs. As in ticket #3513 .

@YongBoLiu YongBoLiu added the enhancement General tag for an enhancement label Nov 24, 2020
@YongBoLiu
Copy link
Contributor Author

YongBoLiu commented Nov 24, 2020

Pull request #3944 created for this.

@TheWitness TheWitness added this to the v1.2.16 milestone Nov 28, 2020
@TheWitness TheWitness changed the title Add hooks for plugins to show customize graph source and customize template url (List View) Add hooks for plugins to show custom Graph Source and custom Template URL (List View) Nov 28, 2020
@TheWitness TheWitness added the resolved A fixed issue label Nov 28, 2020
TheWitness added a commit that referenced this issue Nov 28, 2020
Add hooks for plugins to show custom Graph Source and custom Template URL (List View)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants