Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNMPv3 Password field does not correctly limit to size of database field #3969

Closed
Ratief opened this issue Nov 30, 2020 · 3 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@Ratief
Copy link

Ratief commented Nov 30, 2020

Cacti Version: 1.1.38
OS: Ubuntu 18.04.4 LTS

I am switching to SNMPv3 and it took me almost 2 hours to discover that Cacti is silently limiting the SNMPv3 password length to 50 characters (via HTML maxlength). I have been using a longer password for my Nagios installation so I know that SNMPv3 supports longer passwords. Is where a reason why Cacti is limiting this password? The SNMP community string is limited to 100 characters.

I believe that the default varchar length is 255 and as far as I have researched there is no reason to limit a varchar to less as you will not gain any performance benefits in doing so.

If the above is correct it would be nice if the SNMPv3 password could be increased to 255 characters. The SNMPv3 privacy password should also be increased from 200 to 255 as well (I have no idea why they have different lengths).

@TheWitness
Copy link
Member

It's likely that no one has reported it. Most people us shorter password and passphrases, so this hasn't come up in nearly 18 years. I suspect you are not the first, but the first to report it. It's a trivial fix in any event.

@TheWitness
Copy link
Member

So, upon further review, it may be easy to change the forms, but the table widths are 50 characters for password, and 200 for passphrase. Can you make accommodations for that? If not, we would gladly accept a pull request to fix this.

@TheWitness TheWitness added the bug Undesired behaviour label Dec 3, 2020
TheWitness added a commit that referenced this issue Dec 3, 2020
- SNMPv3 Password Length Limit
- This change does not change the limits, it just will not allow you to enter more characters than are supported.
@TheWitness TheWitness added the resolved A fixed issue label Dec 3, 2020
@TheWitness
Copy link
Member

I have fixed the issue by which you could type more characters than are supported. However, if you want more characters, you will need to submit a pull request for. Thanks for reporting this!

@TheWitness TheWitness added this to the v1.2.17 milestone Dec 3, 2020
@netniV netniV changed the title SNMPv3 Password Length Limit SNMPv3 Password field does not correctly limit to size of database field Jan 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants