Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collation was not always handled correctly in the database library #3985

Closed
TheWitness opened this issue Dec 5, 2020 · 0 comments
Closed

Collation was not always handled correctly in the database library #3985

TheWitness opened this issue Dec 5, 2020 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.17

Comments

@TheWitness
Copy link
Member

Describe the bug

The various Cacti table API don't handle collate correctly when managing tables

Expected behavior

Cacti should handle these table changes without issue.

Context

We had attempted to resolve this in 1.2.16, but did not actually fully resolve it. This bug is affecting Flowview raw table creation.
@TheWitness TheWitness added the bug Undesired behaviour label Dec 5, 2020
@TheWitness TheWitness added this to the v1.2.17 milestone Dec 5, 2020
TheWitness added a commit that referenced this issue Dec 5, 2020
@TheWitness
Fixing Issue #3985
b2fce0a 
Update database library function to properly handle collate
@TheWitness TheWitness added the resolved A fixed issue label Dec 5, 2020
TheWitness added a commit that referenced this issue Dec 19, 2020
@TheWitness
Additional changes around #3985
c57a066 
* Doing collate and charset as separate transactions
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
@netniV netniV changed the title Update database library function to properly handle collate Collation was not always handled correctly in the database library Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.17
Development

No branches or pull requests
1 participant
@TheWitness