Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pollers may sometimes not recover properly once they go offline #4002

Closed
TheWitness opened this issue Dec 12, 2020 · 4 comments
Closed

Pollers may sometimes not recover properly once they go offline #4002

TheWitness opened this issue Dec 12, 2020 · 4 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug

Due to logic in global.php, there are cases where if a remote data collector goes offline, it may not recover as expected, even though it's fully recovered.

Expected behavior

Cacti Remote Data Collectors should report the correct status at all times.

@TheWitness TheWitness added bug Undesired behaviour unverified Some days we don't have a clue and removed unverified Some days we don't have a clue labels Dec 12, 2020
@TheWitness TheWitness added this to the v1.2.17 milestone Dec 12, 2020
@netniV
Copy link
Member

netniV commented Dec 13, 2020

Do you have the circumstances ?

@TheWitness
Copy link
Member Author

It was me doing bad things developing support for Galera. Closing.

@TheWitness
Copy link
Member Author

It's a good think I was testing before committing. Deleted all my devices working with remote data collectors.

@TheWitness
Copy link
Member Author

Reopening. Remember why I opened in the first place. You will see the diff shortly.

@TheWitness TheWitness reopened this Dec 19, 2020
TheWitness added a commit that referenced this issue Dec 19, 2020
* Poller Recovery is not predictable
* The checking for recovery needs to come earlier in the call stack to for the logic below it to be reliable
* Fixing some alignment of variables for readability
@TheWitness TheWitness added the resolved A fixed issue label Dec 19, 2020
@netniV netniV changed the title Poller Recovery is not predictable Pollers may sometimes not recover properly once they go offline Jan 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants