Skip to content

Action Icons changed to be consistent with admin UI #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheWitness opened this issue Jan 5, 2021 · 0 comments
Closed

Action Icons changed to be consistent with admin UI #4033

TheWitness opened this issue Jan 5, 2021 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.17

Comments

@TheWitness
Copy link
Member

Describe the bug

The pull request that was introduced to Hide Graph Action Icons used reverse logic, which confuses most users as permission as assumed to be permissive. So, this behavior needs to be changed as such.

Since it's a new option, users who have implemented the reverse will need to be aware of this change.
@TheWitness TheWitness added the bug Undesired behaviour label Jan 5, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Jan 5, 2021
@TheWitness TheWitness mentioned this issue Jan 5, 2021
Merged
TheWitness added a commit that referenced this issue Jan 5, 2021
@TheWitness
Fixing Issue #4033
d254477 
Change Hide Graph Action Icon's to 'Show' Action Icons
@TheWitness TheWitness added the resolved A fixed issue label Jan 5, 2021
TheWitness added a commit that referenced this issue Jan 6, 2021
@TheWitness
Correcting 2/3 Issues in #4033
cc13fca 
- Two of three issues resolved
- XSS security issue from WebScan report
- Data Template unable to reproduce
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
@netniV netniV changed the title Change Hide Graph Action Icon's to 'Show' Action Icons Invert Action Icons functionality to be consistent with admin UI Apr 12, 2021
@netniV netniV changed the title Invert Action Icons functionality to be consistent with admin UI Action Icons changed to be consistent with admin UI Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.17
Development

No branches or pull requests
1 participant
@TheWitness