Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary data can fail to calculate when the RRDfile lacks the Data Source #4070

Closed
ISekan opened this issue Jan 21, 2021 · 7 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ISekan
Copy link

ISekan commented Jan 21, 2021

cacti 1.2.14
PHP Version | 7.3.22
RRDtool Version Found | 1.7.1
Centos7

How to fix it?

21-Jan-2021 12:53:33 - CMDPHP PHP ERROR NOTICE Backtrace: (/graph_json.php[159]:rrdtool_function_graph(), /lib/rrd.php[1591]:variable_bandwidth_summation(), /lib/graph_variables.php[653]:CactiErrorHandler())
21-Jan-2021 12:53:33 - ERROR PHP NOTICE: Undefined index: traffic_in in file: /var/www/html/cacti/lib/graph_variables.php on line: 653

@bmfmancini
Copy link
Member

bmfmancini commented Jan 21, 2021 via email

@TheWitness
Copy link
Member

Was the RRDfile already created when you received this error message? That 'might' lead to this issue. If it's not repeatable, I'm kind of okay for the moment.

@ISekan
Copy link
Author

ISekan commented Jan 22, 2021

It appears in log every poller cycle. I have a lot of users who can create new graphs and I can't say when the problem started.
image

@TheWitness
Copy link
Member

Can you please update to the 1.2.x branch and let us know if this problem persists. I recall us fixing some issues around this in the last few releases.

@TheWitness
Copy link
Member

Never mind, I think I've found it. Maybe an aggregate graph built from a bogus graph. We might want to log something anyway. For now, I'm going to mask the error.

@TheWitness TheWitness changed the title Undefined index: traffic_in in file: /var/www/html/cacti/lib/graph_variables.php Graph Variable summation fails in some cases when the RRDfile lacks the Data Source Jan 23, 2021
TheWitness added a commit that referenced this issue Jan 23, 2021
- Graph Variable summation fails in some cases when the RRDfile lacks the Data Source
@TheWitness TheWitness added bug Undesired behaviour resolved A fixed issue labels Jan 23, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Jan 23, 2021
@TheWitness
Copy link
Member

TheWitness commented Jan 23, 2021

@Izmenoff Test using the lib/graph_variables.php from the 1.2.x branch and report back.

@ISekan
Copy link
Author

ISekan commented Jan 26, 2021

@Izmenoff Test using the lib/graph_variables.php from the 1.2.x branch and report back.

Thanks! The fix works fine

@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2021
@netniV netniV changed the title Graph Variable summation fails in some cases when the RRDfile lacks the Data Source Summary data can fail to calculate when the RRDfile lacks the Data Source Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants