New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation causes SQL syntax errors when invalid operations are present #4122
Comments
Yea, this is something that needs more attention. It's clear that you have a bug in your syntax. That should be masked for the most part. |
Automation causes SQL syntax errors when invalid Operations are present
Have an update to lib/api_automation.php and if the problem is now masked, please close. |
hey @TheWitness , thanks for the patch. It suppresses one of the errors, but there is still another error, e.g:
This is what I used to reproduce it this time (just clicking Save triggers the errors in the log): |
Oh, did not notice that. |
Correcting one more SQL logging issue.
Check again. Fixed. |
Nice. Thanks! |
Describe the bug
Adding a new "Graph Create Criteria" to an Automation Graph Rule causes an SQL syntax error when and Operation is missing on an item.
To Reproduce
Steps to reproduce the behavior:
Go to
Automation
->Graph Rules
Add a new Rule:
Net-SNMP - Get Monitored Partitions
add two new Graph Creation Criteria, without "Operation", e.g. for field "dskPath", Operator "does not containt", pattern "bla". See screenshots if needed.
Save
Open log; see SQL errors
Expected behaviour
UI should notify user that the Graph Creation Criteria are invalid
Screenshots
Note that
item#6
has no Operation, which causes the SQL syntax error.Log entires
Additional context
Cacti version: 1.2.16
The text was updated successfully, but these errors were encountered: