Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On completing the installation wizard, an internal server error can sometimes be observed #4125

Closed
dlynes opened this issue Feb 14, 2021 · 6 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@dlynes
Copy link

dlynes commented Feb 14, 2021

There is an error on line 4119 of cacti/lib/functions.php:

$logcontents = tail_file($config['base_path'] . '/log/cacti.log', 100, -1, ' INSTALL:' , $page_nr, $total_rows);

It should have the ", $total_rows" removed from the end. The tail_file function uses a default of 0 for total_rows, and total_rows is not defined in getInstallLog() in functions.php. That is why the HTTP 500 is produced.

@dlynes dlynes added bug Undesired behaviour unverified Some days we don't have a clue labels Feb 14, 2021
@TheWitness
Copy link
Member

What version of Cacti is this? What version of PHP is this?

@TheWitness TheWitness removed the unverified Some days we don't have a clue label Feb 17, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Feb 17, 2021
@TheWitness
Copy link
Member

Okay, I've confirmed. I'm guessing php74 or php8x.

TheWitness added a commit that referenced this issue Feb 17, 2021
At the end of install, cacti produces an HTTP 500
@TheWitness TheWitness added the resolved A fixed issue label Feb 17, 2021
TheWitness added a commit that referenced this issue Feb 17, 2021
@dlynes
Copy link
Author

dlynes commented Feb 17, 2021 via email

@dlynes
Copy link
Author

dlynes commented Feb 17, 2021 via email

@dlynes
Copy link
Author

dlynes commented Feb 17, 2021

Just an FYI, that parameter of ', 500' wasn't in the git code I grabbed. It was ', $total_rows', but $total_rows wasn't defined.

@TheWitness
Copy link
Member

Need to merge 1.2.x with develop. Was not able to do it due to a GitHub desktop bug. Have to see if it's fixed now.

@netniV netniV changed the title At the end of install, cacti produces an HTTP 500 At the end of install, an internal server error can sometimes be observed Apr 30, 2021
@netniV netniV changed the title At the end of install, an internal server error can sometimes be observed On completing the installation wizard, an internal server error can sometimes be observed Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants