Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When updating Trees, graph titles are calculated too often leading to unresponsiveness #4127

Closed
TheWitness opened this issue Feb 15, 2021 · 0 comments
Closed

When updating Trees, graph titles are calculated too often leading to unresponsiveness #4127

TheWitness opened this issue Feb 15, 2021 · 0 comments
Labels
bug Undesired behaviour performance Performance related affects big sites resolved A fixed issue
Milestone
v1.2.17

Comments

@TheWitness
Copy link
Member

Describe the bug

The get_graph_title() function auto-recalculates the Graph Title, which leads to more queries, a slower GUI, and some graphs that have inconsistent names. Need a title cache calling function instead.

To Reproduce

Simply have a Data Query Graph that is missing an index. From the Cacti Graphs page, the Graph still has it's proper name, but when you place it on the Tree, it has a bogus name.

Expected behavior

Cacti should use the correct name.
@TheWitness TheWitness added the bug Undesired behaviour label Feb 15, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Feb 15, 2021
@TheWitness TheWitness added the resolved A fixed issue label Feb 15, 2021
TheWitness added a commit that referenced this issue Feb 15, 2021
@TheWitness
Fixing Issue #4127
3398d8c 
Tree Editing used get_graph_title() function which results in unexpected behavior
@TheWitness TheWitness added the performance Performance related affects big sites label Feb 17, 2021
@netniV netniV changed the title Tree Editing used get_graph_title() function which results in unexpected behavior When updating Trees, graph titles are calculated too often leading to unresponsiveness Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour performance Performance related affects big sites resolved A fixed issue
Projects
None yet
Milestone
v1.2.17
Development

No branches or pull requests
1 participant
@TheWitness