Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent some false positive scenarios when detection orphan graphs #4143

Closed
TheWitness opened this issue Feb 22, 2021 · 0 comments
Closed

Prevent some false positive scenarios when detection orphan graphs #4143

TheWitness opened this issue Feb 22, 2021 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.17

Comments

@TheWitness
Copy link
Member

Describe the bug

There are nuances to Cacti's orphan detection, and some of the assumptions that the current algorithm is using are not complete.

Expected behavior

Removing orphans can lead to unintended consequences. We should ensure that this is not allowed.
@TheWitness TheWitness added the bug Undesired behaviour label Feb 22, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Feb 22, 2021
TheWitness added a commit that referenced this issue Feb 22, 2021
@TheWitness
Fixing Issue #4143
2160be7 
- Cacti's Graph Orhan detection is too aggressive leading to false positives
@TheWitness TheWitness added the resolved A fixed issue label Feb 22, 2021
TheWitness added a commit that referenced this issue Feb 22, 2021
@TheWitness
Another modification for #4143
2b1a0f4 
- This makes both the Graph and Data Sources UI consistent and speeds up the Orphan Detection by orders of magnitude.
@netniV netniV changed the title Cacti's Graph Orhan detection is too aggressive leading to false positives Prevent some false positive scenarios when detection orphan graphs Apr 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.17
Development

No branches or pull requests
1 participant
@TheWitness