Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data source template names should be shown in the respective "suggested values" sections #4161

Closed
bernisys opened this issue Mar 9, 2021 · 4 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@bernisys
Copy link
Contributor

bernisys commented Mar 9, 2021

Describe the bug

Data source template names are not shown in the list for the suggested values for data sources, if multiple data source templates are used in the connected graph.

(Not sure if it is wise to create such a query, but we just produced this scenario.)

To Reproduce

Create 2 data source templates
Create a graph using both data source templates
Create a data query and add the graph template
Check the "Suggested Values - Data Sources" section
You will see two sections listed belonging to the two data sources, but there is no way to distinguish, which of the DS each of them is connected to.

Expected behavior

Show the DS template names, as it is done in the "Associated Data Templates" section above.

Screenshots

cacti-query-edit-datasource-hint-missing

I have added already a "name" pattern for both, one suffexed "first" and the other one "second" to find out which is which.
I assume that the first one corresponds with the first DS also shown in the top section for the variable-assignment.

@bernisys bernisys added bug Undesired behaviour unverified Some days we don't have a clue labels Mar 9, 2021
@TheWitness
Copy link
Member

I looked at this and said to myself "how did that happen". But I've only now gotten enough time to really read the bug. Yea, that makes sense though doesn't it. I'm not saying the behavior is desirable, but I can see how that would happen since there are two data sources technically, and each can have it's own suggested name. Like "|host_description| - Power in Amps" and "|host_description| - Temperature in Celsius". So, it kind of does make sense doesn't it?

But maybe the questions is "I can tell this one from that one. There is not enough labeling". Well that's easier to fix. I think that's the ticket. Okay.

TheWitness added a commit that referenced this issue Mar 19, 2021
Data source template names should be shown in the respective "suggested values" sections
@TheWitness TheWitness removed the unverified Some days we don't have a clue label Mar 19, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Mar 19, 2021
@TheWitness
Copy link
Member

Okay, all better. All on a good glass of zinfandel.

@TheWitness TheWitness added the resolved A fixed issue label Mar 19, 2021
@bernisys
Copy link
Contributor Author

Well reasoned recap of yours :) And yup, the fix looks pretty reasonable to me, that should do the trick. Cheers!

Thanks for also pushing this small thing directly into 17 ;)
Rough idea when it will be released finally?

@TheWitness
Copy link
Member

Soon.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants