Ensure error logging is consistent when using CMD processor instead of spine #4184
Description
Describe the bug
When cmd.php encounters response errors, it currently does not, though it attempts to log errors using the rules setup for spine, but it is not properly following those rules.
cmd.php below shows errors as 1 for each polling item, even though the detail levels is 'None'
2021-03-20 05:51:06 - POLLER: Poller[Main Poller] WARNING: Invalid Response(s), Errors[1] Device[vhost08] Thread[1] DS[vhost04 - Interrupts] Graphs[vhost04 - Interrupts]
--
2021-03-20 05:51:06 - POLLER: Poller[Main Poller] WARNING: Invalid Response(s), Errors[1] Device[vhost08] Thread[1] DS[vhost04 - Memory - Cache] Graphs[vhost04 - Memory Usage]
2021-03-20 05:51:06 - POLLER: Poller[Main Poller] WARNING: Invalid Response(s), Errors[1] Device[vhost08] Thread[1] DS[vhost04 - Memory - Buffers] Graphs[vhost04 - Memory Usage]
2021-03-20 05:51:06 - POLLER: Poller[Main Poller] WARNING: Invalid Response(s), Errors[1] Device[vhost08] Thread[1] DS[vhost04 - Polling Time] Graphs[vhost04 - Polling Time]
2021-03-20 05:51:06 - POLLER: Poller[Main Poller] WARNING: Invalid Response(s), Errors[1] Device[vhost08] Thread[1] DS[vhost04 - CPU - User] Graphs[vhost04 - CPU Utilization]
2021-03-20 05:51:06 - POLLER: Poller[Main Poller] WARNING: Invalid Response(s), Errors[1] Device[vhost08] Thread[1] DS[vhost04 - CPU - System] Graphs[vhost04 - CPU Utilization]
2021-03-20 05:51:06 - POLLER: Poller[Main Poller] WARNING: Invalid Response(s), Errors[1] Device[vhost08] Thread[1] DS[vhost04 - CPU - Idle] Graphs[vhost04 - CPU Utilization]
For spine, it follow levels fine. Under 'none', not logging is performed, at summary, you get the following:
2021-03-20 05:54:02 - SPINE: Poller[Main Poller] PID[17538] WARNING: Invalid Response(s), Errors[1] Device[vhost01] Thread[1] DS[vhost01 - Ping Host] Graphs[vhost01 - Ping Latency]
--
2021-03-20 05:54:01 - SPINE: Poller[Main Poller] PID[17538] WARNING: Invalid Response(s), Errors[11] Device[Adams Basement] Thread[1] DS[Adams Basement - 12.0 Voltage, Adams Basement - 5.0 Voltage, Adams Basement - 3.3 Voltage, Adams Basement - Core Voltage, Adams Basement - Voltage, Adams Basement - CPU Temperature, Adams Basement - Processor Temperature, Adams Basement - Sensor Temperature, Adams Basement - Temperature, Adams Basement - Power, Adams Basement - Current] Graphs[Adams Basement - `12.0 Voltage`, Adams Basement - 5.0 Voltage, Adams Basement - 3.3 Voltage, Adams Basement - Core Voltage, Adams Basement - Voltage, Adams Basement - CPU Temperature, Adams Basement - Processor Temperature, Adams Basement - Sensor Temperature, Adams Basement - Temperature, Adams Basement - Power Consumption, Adams Basement - Current Utilization]
2021-03-20 05:54:01 - SPINE: Poller[Main Poller] PID[17538] WARNING: Invalid Response(s), Errors[11] Device[MikroTik] Thread[1] DS[MikroTik - 12.0 Voltage, MikroTik - 5.0 Voltage, MikroTik - 3.3 Voltage, MikroTik - Core Voltage, MikroTik - Voltage, MikroTik - CPU Temperature, MikroTik - Processor Temperature, MikroTik - Sensor Temperature, MikroTik - Temperature, MikroTik - Power, MikroTik - Current] Graphs[MikroTik - `12.0 Voltage`, MikroTik - 5.0 Voltage, MikroTik - 3.3 Voltage, MikroTik - Core Voltage, MikroTik - Voltage, MikroTik - CPU Temperature, MikroTik - Processor Temperature, MikroTik - Sensor Temperature, MikroTik - Temperature, MikroTik - Power Consumption, MikroTik - Current Utilization]
2021-03-20 05:54:01 - SPINE: Poller[Main Poller] PID[17538] WARNING: Invalid Response(s), Errors[9] Device[Adams MikroTik] Thread[1] DS[Adams MikroTik - Sensor Temperature, Adams MikroTik - Power, Adams MikroTik - Current, Adams MikroTik - 12.0 Voltage, Adams MikroTik - 5.0 Voltage, Adams MikroTik - 3.3 Voltage, Adams MikroTik - Core Voltage, Adams MikroTik - CPU Temperature, Adams MikroTik - Processor Temperature] Graphs[Adams MikroTik - `12.0 Voltage`, Adams MikroTik - 5.0 Voltage, Adams MikroTik - 3.3 Voltage, Adams MikroTik - Core Voltage, Adams MikroTik - CPU Temperature, Adams MikroTik - Processor Temperature, Adams MikroTik - Sensor Temperature, Adams MikroTik - Power Consumption, Adams MikroTik - Current Utilization]
2021-03-20 05:54:01 - SPINE: Poller[Main Poller] PID[17542] WARNING: Invalid Response(s), Errors[11] Device[MikroTik] Thread[1] DS[MikroTik - 12.0 Voltage, MikroTik - 5.0 Voltage, MikroTik - 3.3 Voltage, MikroTik - Core Voltage, MikroTik - Voltage, MikroTik - CPU Temperature, MikroTik - Processor Temperature, MikroTik - Sensor Temperature, MikroTik - Temperature, MikroTik - Power, MikroTik - Current] Graphs[MikroTik - `12.0 Voltage`, MikroTik - 5.0 Voltage, MikroTik - 3.3 Voltage, MikroTik - Core Voltage, MikroTik - Voltage, MikroTik - CPU Temperature, MikroTik - Processor Temperature, MikroTik - Sensor Temperature, MikroTik - Temperature, MikroTik - Power Consumption, MikroTik - Current Utilization]
And detailed looks as follows:
2021-03-20 05:55:31 - SPINE: Poller[Main Poller] PID[19759] WARNING: Invalid Response, Device[MikroTik] HT[1] DS[MikroTik - 3.3 Voltage] Graphs[MikroTik - 3.3 Voltage] SCRIPT: /var/www/html/cacti/plugins/mikrotik/templates/scripts/ss_mikrotik_health.php ss_mikrotik_health '114' 'HlThreeDotThreeVoltage', output:
--
2021-03-20 05:55:31 - SPINE: Poller[Main Poller] PID[19756] WARNING: Invalid Response, Device[Adams MikroTik] HT[1] DS[Adams MikroTik - 5.0 Voltage] Graphs[Adams MikroTik - 5.0 Voltage] SCRIPT: /var/www/html/cacti/plugins/mikrotik/templates/scripts/ss_mikrotik_health.php ss_mikrotik_health '68' 'HlFiveVoltage', output:
2021-03-20 05:55:31 - SPINE: Poller[Main Poller] PID[19759] WARNING: Invalid Response, Device[MikroTik] HT[1] DS[MikroTik - 5.0 Voltage] Graphs[MikroTik - 5.0 Voltage] SCRIPT: /var/www/html/cacti/plugins/mikrotik/templates/scripts/ss_mikrotik_health.php ss_mikrotik_health '114' 'HlFiveVoltage', output:
2021-03-20 05:55:31 - SPINE: Poller[Main Poller] PID[19759] WARNING: Invalid Response, Device[MikroTik] HT[1] DS[MikroTik - 12.0 Voltage] Graphs[MikroTik - `12.0 Voltage`] SCRIPT: /var/www/html/cacti/plugins/mikrotik/templates/scripts/ss_mikrotik_health.php ss_mikrotik_health '114' 'HlTwelveVoltage', output:
2021-03-20 05:55:31 - SPINE: Poller[Main Poller] PID[19756] WARNING: Invalid Response, Device[Adams MikroTik] HT[1] DS[Adams MikroTik - 12.0 Voltage] Graphs[Adams MikroTik - `12.0 Voltage`] SCRIPT: /var/www/html/cacti/plugins/mikrotik/templates/scripts/ss_mikrotik_health.php ss_mikrotik_health '68' 'HlTwelveVoltage', output:
2021-03-20 05:55:31 - SPINE: Poller[Main Poller] PID[19756] WARNING: Invalid Response, Device[Adams MikroTik] HT[1] DS[Adams MikroTik - Current] Graphs[Adams MikroTik - Current Utilization] SCRIPT: /var/www/html/cacti/plugins/mikrotik/templates/scripts/ss_mikrotik_health.php ss_mikrotik_health '68' 'HlCurrent', output:
2021-03-20 05:55:31 - SPINE: Poller[Main Poller] PID[19756] WARNING: Invalid Response, Device[Adams MikroTik] HT[1] DS[Adams MikroTik - Power] Graphs[Adams MikroTik - Power Consumption] SCRIPT: /var/www/html/cacti/plugins/mikrotik/templates/scripts/ss_mikrotik_health.php ss_mikrotik_health '68' 'HlPower', output:
2021-03-20 05:55:31 - SPINE: Poller[Main Poller] PID[19756] WARNING: Invalid Response, Device[Adams MikroTik] HT[1] DS[Adams MikroTik - Sensor Temperature] Graphs[Adams MikroTik - Sensor Temperature] SCRIPT: /var/www/html/cacti/plugins/mikrotik/templates/scripts/ss_mikrotik_health.php ss_mikrotik_health '68' 'HlSensorTemperature', output: