Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Signal Handling to recommended standards for PHP 7.1+ #4185

Closed
TheWitness opened this issue Mar 20, 2021 · 1 comment
Closed

Updating Signal Handling to recommended standards for PHP 7.1+ #4185

TheWitness opened this issue Mar 20, 2021 · 1 comment
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.17

Comments

@TheWitness
Copy link
Member

Describe the bug

Cacti signal handling has defined ticks = 1 for several years. However, as of PHP7.1, there is a new best practice to use a new function, and Cacti is not following that best practice.

Expected behavior

Cacti should follow best practices.
@TheWitness TheWitness added the bug Undesired behaviour label Mar 20, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Mar 20, 2021
@TheWitness TheWitness added the resolved A fixed issue label Mar 20, 2021
TheWitness added a commit that referenced this issue Mar 20, 2021
@TheWitness
Fixing Issue #4185 - Signal Handling Best Practices
c25ab9c 
- Cacti signal handling is not following best practices in PHP 7
@netniV
Copy link
Member

netniV commented Apr 30, 2021

The function can be present but unusable if it is in the following list:

https://stackoverflow.com/questions/52791039/pcntl-async-signals-has-been-disabled-for-security-reasons-ubuntu-16-lara

disable_functions = pcntl_alarm,pcntl_fork,pcntl_waitpid........

@netniV netniV changed the title Cacti signal handling is not following best practices in PHP 7 Updating Signal Handling to recommended standards for PHP 7.1+ Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.17
Development

No branches or pull requests
2 participants
@TheWitness @netniV