Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When search text includes # character, filtering does not always work as expected #4195

Closed
ikorzha opened this issue Mar 23, 2021 · 4 comments
Closed

When search text includes # character, filtering does not always work as expected #4195

ikorzha opened this issue Mar 23, 2021 · 4 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.17

Comments

@ikorzha
Copy link

ikorzha commented Mar 23, 2021 •
edited

Cacti->Management->Devices search return blank description, ID & hostname if device name contain # character .

Using the Cacti version 1.2.17 (patched), with an updated monitor plugin 2.5 (development branch).
Broswer Crome incognito mode for testing.
This is a an extension to original bug #4192 that TheWitness has successfully patched yesterday..

Please see an updated behavior below:
cacti-search-bug
@ikorzha ikorzha added bug Undesired behaviour unverified Some days we don't have a clue labels Mar 23, 2021
@TheWitness TheWitness changed the title Cacti->Management->Devices search return blank description, ID & hostname if device name contain # character filter_value() function does not work as expected when search includes # character Mar 23, 2021
@TheWitness TheWitness removed the unverified Some days we don't have a clue label Mar 23, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Mar 23, 2021
TheWitness added a commit that referenced this issue Mar 23, 2021
@TheWitness
Fixing Issue #4195 - filter_value() quoting
44a5574 
filter_value() function does not work as expected when search includes # character
@TheWitness TheWitness added the resolved A fixed issue label Mar 23, 2021
@TheWitness
Copy link
Member

The # character had a special use in the preg_match. All fixed up now.

@ikorzha
Copy link
Author

ikorzha commented Mar 24, 2021

My apologies, I have tested a patched lib/functions.php and still getting an identical behavior to reported, is there a way you can test it yourself for validation?
image

@TheWitness
Copy link
Member

Works here:

image

@ikorzha
Copy link
Author

ikorzha commented Mar 24, 2021 •
edited

maybe because I pulled lib/functions.php into my 1.2.16 I do not to try to upgrade to development version.
If it works for you close it at this point..
Tried to upgrade to development version but installation has failed :( will wait until 1.2.17 officially released at this point

@netniV netniV changed the title filter_value() function does not work as expected when search includes # character When search text includes # character, filtering does not always work as expected Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.17
Development

No branches or pull requests
2 participants
@TheWitness @ikorzha