Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a report was delayed, the report's time is incorrectly changed #4206

Closed
bernisys opened this issue Mar 30, 2021 · 5 comments
Closed

When a report was delayed, the report's time is incorrectly changed #4206

bernisys opened this issue Mar 30, 2021 · 5 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@bernisys
Copy link
Contributor

Describe the bug

Not sure if this is a bug or more a feature request. But we've seen this several times in the past:
When cacti fails to generate a report at its specific time, it will be generated later, but also the time is adapted.
This should not happen, as some reports might be expected at specific predefined times, but we see that from time to time, when cacti had a hicc-up and generates the report after its specified time.

It is good that it sends out delayed reports, no question here, but the times should be kept intact.

To Reproduce

  1. create a daily report to be sent within specific time of the day (for simulation, choose a time in near future)
  2. stop cacti for a while (simulating a temporary outage, that crosses the defined report time)
  3. restart cacti processing, wait for the delayed report to be generated
  4. check the report time again & compare with previous setting

Expected behavior

Report time should stay as previously configured.

@bernisys bernisys added bug Undesired behaviour unverified Some days we don't have a clue labels Mar 30, 2021
@TheWitness
Copy link
Member

Okay, I audited this function and I'm pretty sure I found the issue. The function itself was trying, in a bad way to normalize the mailtime, when it should just increase it as applicable. Please test wit h the latest lib/reports.php.

@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Apr 3, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Apr 3, 2021
@TheWitness
Copy link
Member

Confirmed working as expected now in my testing.

@bernisys
Copy link
Contributor Author

bernisys commented Apr 6, 2021

Hmm i think you annotated the wrong issue when fixing it ...
/lib/reports.php has a closed bug #4205 but this bug is #4206
in the changelog you correctly listed 4206

easter stress i assume :)

@TheWitness
Copy link
Member

Working too late or too early. Also, I think I need glasses.

bernisys referenced this issue Apr 6, 2021
Configured report's time changes when a report was delayed
@bernisys
Copy link
Contributor Author

bernisys commented Apr 6, 2021

Get a glass of your favorite then - cheers!

@netniV netniV changed the title Configured report's time changes when a report was delayed When a report was delayed, the configured report's time is incorrectly changed Apr 30, 2021
@netniV netniV changed the title When a report was delayed, the configured report's time is incorrectly changed When a report was delayed, the report's time is incorrectly changed Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants