Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential typos and incomplete parameter lists for database connection variables #4233

Closed
ctrowat opened this issue Apr 14, 2021 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ctrowat
Copy link
Contributor

ctrowat commented Apr 14, 2021

/install/functions.php:remote_update_config_file():

  • The parameters $rdatabase_ssl_key ,$rdatabase_ssl_cert, $rdatabase_ssl_ca, $database_ssl_key, $database_ssl_cert, $database_ssl_ca are not brought in as globals
  • The parameters $rdatabase_ssl_key $rdatabase_ssl_cert $rdatabase_ssl_ca are not passed in the function call db_connect_real()
  • The parameters $database_ssl_key, $database_ssl_cert, $database_ssl_ca are not persisted in the $save object when configuring the remote poller

/install/functions.php:install_test_local_database_connection():

  • There seems to be a copy and paste error around line 88, the parameters are checked as $database... but set as $rdatabase...
@ctrowat ctrowat added bug Undesired behaviour unverified Some days we don't have a clue labels Apr 14, 2021
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Apr 14, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Apr 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants