-
-
Notifications
You must be signed in to change notification settings - Fork 438
Closed
Labels
bugUndesired behaviourUndesired behaviouroutdatedNo recent activityNo recent activityresolvedA fixed issueA fixed issue
Milestone
Description
Describe the bug
The fix for #3340 (621091f) added an early return when encountering a NaN data source.
This has stopped percentiles working on graphs with multiple data sources.
To Reproduce
Steps to reproduce the behavior:
- Create two data sources, one with data and the other with NaN's
- Create a graph using
aggregate_currentpercentiles (e.g.|95:bits:0:aggregate_current:2|) across the two data sources. - View the graph
- Percentiles are shown as 0
Expected behavior
Percentile calculation should ignore the NaN data source(s) and be based on any remaining sources with data.
Additional context
I've locally removed the early return from nth_percentile_fetch_statistics and the graphs appear to be working correctly:
--- lib/graph_variables.php
+++ lib/graph_variables.php
@@ -182,8 +182,6 @@ function nth_percentile_fetch_statistics($percentile, &$local_data_ids, &$fetch_array, $cf) {
$asum_array[$ds_name][$timestamp] = $data;
}
}
- } else {
- return false;
}
}
}Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugUndesired behaviourUndesired behaviouroutdatedNo recent activityNo recent activityresolvedA fixed issueA fixed issue