Installation Wizard can become stuck when creating graphs for default device

[BSOD2600]

Describe the bug

On the final screen of the Installation Wizard, it gets stuck in a loop 'creating graphs for default device'. No option to advance past this screen.
Fresh install from release/1.2.17

To Reproduce

Install on Windows without a snmp agent running locally.

Screenshots

In this screenshot, its already been 5 minutes with no progress change.

Desktop (please complete the following information)

• OS: Windows
• Browser: Edge
• Version 90.x

Additional context

php error log

[17-May-2021 15:45:45 America/Los_Angeles] PHP Fatal error: Uncaught Error: Call to undefined function cacti_snmp_session() in C:\Apache24\htdocs\cacti\lib\functions.php:1771 Stack trace: #0 C:\Apache24\htdocs\cacti\lib\functions.php(1594): test_data_source() #1 C:\Apache24\htdocs\cacti\lib\api_automation.php(2351): test_data_sources() #2 C:\Apache24\htdocs\cacti\lib\installer.php(3170): automation_execute_graph_template() #3 C:\Apache24\htdocs\cacti\lib\installer.php(2889): Installer->installServer() #4 C:\Apache24\htdocs\cacti\lib\installer.php(3387): Installer->install() #5 C:\Apache24\htdocs\cacti\install\background.php(54): Installer::beginInstall() #6 {main} thrown in C:\Apache24\htdocs\cacti\lib\functions.php on line 1771

[netniV]

Pretty sure that cacti_snmp_session lives in lib/snmp.php, so that would suggest it isn't being included from a place where automation is taking place during the installer.

[netniV]

The problem here is there is a jump between the installer class, the automation class and the functions class. And the lib/snnmp isn't included by any of them. I am guessing, lib/api_automation should really be the one to include_once('lib/snmp=.php');

Can you test that out and see if it's as simple as that?

[TheWitness]

That's weird, I mean shouldn't it be included already.

[TheWitness]

Just checked, it's included where needed.

[TheWitness]

I committed something. Please test.

[netniV]

Any update @BSOD2600 ?

[ohlala9876]

Fresh install from release/1.2.17
The same error. Stuck in 73%

[ohlala9876]

SAME PHP ERROR:

[22-Jun-2021 19:26:17 America/Los_Angeles] PHP Fatal error: Uncaught Error: Call to undefined function cacti_snmp_session() in C:\Apache24\htdocs\cacti\lib\functions.php:1771
Stack trace:
#0 C:\Apache24\htdocs\cacti\lib\functions.php(1594): test_data_source()
#1 C:\Apache24\htdocs\cacti\lib\api_automation.php(2351): test_data_sources()
#2 C:\Apache24\htdocs\cacti\lib\installer.php(3170): automation_execute_graph_template()
#3 C:\Apache24\htdocs\cacti\lib\installer.php(2889): Installer->installServer()
#4 C:\Apache24\htdocs\cacti\lib\installer.php(3387): Installer->install()
#5 C:\Apache24\htdocs\cacti\install\background.php(54): Installer::beginInstall()
#6 {main}
thrown in C:\Apache24\htdocs\cacti\lib\functions.php on line 1771