Support execution of custom functions at poller bottom for remote pollers

[browniebraun]

Feature Request

Hook 'poller_finishing' could probably used for that approach too, but I'm wondering why we are not supporting a hook to perform individual plugin tasks at the bottom of a remote poller run.

The current code of poller.php does not take this case into account - If I'm not totally wrong. From my point of view a remote poller is not just stupid collector. It should be workhorse.

`/* start post data processing */
if ($poller_id == 1) {
	multiple_poller_boost_check();
	poller_replicate_check();
	snmpagent_poller_bottom();
	boost_poller_bottom();
	dsstats_poller_bottom();
	dsdebug_poller_bottom();
	reports_poller_bottom();
	spikekill_poller_bottom();
	automation_poller_bottom();
	poller_maintenance();
	api_plugin_hook('poller_bottom');
	bad_index_check($mibs);
} else {
	// flush the boost table if in recovery mode
	if ($poller_id > 1 && $config['connection'] == 'recovery') {
		cacti_log('NOTE: Remote Data Collection to force processing of boost records.', true, 'POLLER');
		poller_recovery_flush_boost($poller_id);
	}
	automation_poller_bottom();
	poller_maintenance();
}
`

[netniV]

The reason for this is to process all data that is now gathered back on the main poller at the end of the cycle. I would imagine if you want it on a remote poller I guess it should come under poller_maintainence() ?

[browniebraun]

yep, that's the right place to execute tasks e.g. for hosts a remote poller is handling.

[browniebraun]

Well, you know I'm most probably the only one using the RRDproxy as data backend, but it offers you the option to make the remote pollers more independent. ;)

[TheWitness]

remote_maint:1?

[browniebraun]

Good point. extending the capabilities would be useful.

[TheWitness]

Let's make that the plan then.

[TheWitness]

You know, we need to spend some of our funds to get together again. Airfares are too high right now though. Stupid COVID. Blame the Chinese Communist Party, the US government, the NIH, and the Department of Defense for colluding in biological warfare research.

[browniebraun]

I would really love meeting again in person.

[TheWitness]

Yea, before we start expiring...

[netniV]

@browniebraun to meet you in person... walk to a mirror... and wave :)

[bmfmancini]

Hahaha!! It too me a second this made. My morning

…

On Fri., Oct. 29, 2021, 12:33 Mark Brugnoli-Vinten, < ***@***.***> wrote: @browniebraun <https://github.com/browniebraun> to meet you in person... walk to a mirror... and wave :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4417 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADGEXTHT7M32IEUKNZS4VS3UJLLHXANCNFSM5FRHNC5A> .

[browniebraun]

lol. Already done. Damn! I'm old and gray. 😉

[TheWitness]

I'm half past dead. @bmfmancini did we kind of already get this one with the changes for syslog?

[netniV]

Currently poller.php has two hooks for poller_bottom but doesn't pass data to suggest which place it's calling from (in the loop or out of it).

[TheWitness]

Okay, new hook in poller_maintenance.php called poller_remote_maint and only run on Remote Data Collectors. Documentation site updated as well.