Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When renaming poller errors occour #4443

Closed
bmfmancini opened this issue Oct 25, 2021 · 1 comment
Closed

When renaming poller errors occour #4443

bmfmancini opened this issue Oct 25, 2021 · 1 comment
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.19

Comments

@bmfmancini
Copy link
Member

When renaming a poller the following occours occour

2021-10-25 13:10:08 - CMDPHP SQL Backtrace: (/pollers.php[231]:form_save(), /pollers.php[307]:poller_check_duplicate_poller_id(), /pollers.php[404]:db_fetch_cell_prepared(), /lib/database.php[427]:db_execute_prepared())
2021-10-25 13:10:08 - CMDPHP ERROR: A DB Cell Failed!, Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ')' at line 1
@bmfmancini bmfmancini added bug Undesired behaviour unverified Some days we don't have a clue labels Oct 25, 2021
@TheWitness TheWitness changed the title [1.2.19] When renaming poller errors occour When renaming poller errors occour Oct 25, 2021
TheWitness added a commit that referenced this issue Oct 25, 2021
@TheWitness
Fixing Issue #4443 - Renaming poller generates SQL Error
1c041f7 
When renaming poller errors occour.  Corrrected this by simplifying the logic slightly and removing both injection vectors and uncaught exceptions.
@TheWitness
Copy link
Member

Please test the latest pollers.php.

@TheWitness TheWitness added this to the v1.2.19 milestone Oct 25, 2021
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Oct 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.19
Development

No branches or pull requests
2 participants
@TheWitness @bmfmancini