Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing spikes by Variance does not appear to be working beyond the first RRA #4444

Closed
TheWitness opened this issue Oct 25, 2021 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug

Removing spikes from RRA's beyond the first does not currently appear to be working as expected. Instead, the graphs come back as it with zero alterations. This appears to involve not just the AVERAGE CF, but others as well.

To Reproduce

Steps to reproduce the behavior:

  1. Find a Graph with Spikes

  2. Run a Dry Run Using Variance and not it detects spikes

  3. Attempt to Remove those Spikes

  4. Not only are spikes not removed, not report is displayed on screen

Expected behavior

  1. The spikes that were identified in the dry run should be replaced as expected.
  2. The report at the end of the Spikekill should be displayed in a dialog
@TheWitness TheWitness added the bug Undesired behaviour label Oct 25, 2021
@TheWitness TheWitness added this to the v1.2.19 milestone Oct 25, 2021
TheWitness added a commit that referenced this issue Oct 26, 2021
Removing spikes by Variance does not appear to be working beyond the first RRA
@TheWitness TheWitness changed the title Removing spikes by Varience does not appear to be working beyond the first RRA Removing spikes by Variance does not appear to be working beyond the first RRA Oct 26, 2021
@TheWitness TheWitness added the resolved A fixed issue label Oct 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant