Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When handling plugin dependancies, notices may not be displayed properly #4539

Closed
browniebraun opened this issue Jan 31, 2022 · 4 comments
Closed
Labels
bug Undesired behaviour plugins Plugin related issue resolved A fixed issue
Milestone

Comments

@browniebraun
Copy link
Member

Describe the bug

This issue has been noticed in 1.2.19. Unfortunately there was no time to verify if 1.2.20 is affected, too.

To Reproduce

  • Create two plugins A and B.
  • Define within the manifest of B: "requires A"
  • Ensure that A is NOT installed.
  • Click on the install button for plugin B.

Following output will be returned instead of an error message that A has not been installed yet:

image

@browniebraun browniebraun added bug Undesired behaviour unverified Some days we don't have a clue plugins Plugin related issue and removed unverified Some days we don't have a clue labels Jan 31, 2022
TheWitness added a commit that referenced this issue Jan 31, 2022
Broken handling of plugin dependencies in 1.2.19
@TheWitness TheWitness added the resolved A fixed issue label Jan 31, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Jan 31, 2022
@TheWitness
Copy link
Member

Should be fixed now.

@TheWitness
Copy link
Member

@browniebraun do you have an update?

@browniebraun
Copy link
Member Author

Sorry, I haven't received any kind of notification.
But yes, you fixed it.

@TheWitness
Copy link
Member

Cool. Found a few more too.

@netniV netniV changed the title Broken handling of plugin dependencies in 1.2.19 When handling plugin dependancies, notices may not be displayed properly Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour plugins Plugin related issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants