Rounding causes errors with variable substitution

[densenator]

I get some errors in my log file. Please help me

08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1949]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())

08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203
08.02.2022 10:21:09 - CMDPHP PHP ERROR Backtrace: (/graph_realtime.php[218]:rrdtool_function_graph(), /lib/rrd.php[1583]:rrd_substitute_host_query_data(), /lib/rrd.php[2515]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())
08.02.2022 10:21:09 - ERROR PHP DEPRECATED: Implicit conversion from float 2741440.6 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203

Desktop (please complete the following information)

• OS: debian 11.2.0

• php 8.1

• Apache 2.4.52

• 10.5.12-MariaDB-0+deb11u1 Debian 11

• installed on root directory instead of cacti
  -cacti Version 1.2.20

• Browser [e.g. chrome, safari]

• chrome 98.0.4758.82

[TheWitness]

Change the command from intval() to floor() and see if the problem goes away. It's here:

        $allindex    = ($elements - 1) * $p;
        $intvalindex = floor($allindex);
        $floatval    = $allindex - $intvalindex;

[TheWitness]

I committed the update.

[densenator]

Not fixed.

09.02.2022 11:49:29 - CMDPHP PHP ERROR Backtrace: (/data_templates.php[44]:form_save(), /data_templates.php[253]:push_out_data_source(), /lib/template.php[221]:update_data_source_title_cache_from_template(), /lib/variables.php[37]:update_data_source_title_cache(), /lib/variables.php[99]:get_data_source_title(), /lib/functions.php[2449]:expand_title(), /lib/variables.php[234]:substitute_host_data(), /lib/variables.php[313]:get_uptime(), /lib/functions.php[5181]:get_daysfromtime(), /lib/functions.php[5203]:CactiErrorHandler())

09.02.2022 11:49:29 - ERROR PHP DEPRECATED: Implicit conversion from float 59626.9 to int loses precision in file: /var/www/html/lib/functions.php on line: 5203

[TheWitness]

What's on line 5203 in your version?

[densenator]

    foreach ($mods as $index => $mod) {
            if ($mod > 0 || $secs) {
                    if ($time >= $mod) {
                            if ($mod < 1) {
                                    $mod = 1;
                            }
                            $val   = floor($time/$mod);

5203 - $time %= $mod;
} else {
$val = 0;
}

                    if ($all || $val > 0) {
                            $result .= padleft($pad, $val, 2) . $text['prefix'] . $text[$index] . $text['suffix'];
                            $all = true;
                    }
            }
    }

[TheWitness]

In my version of lib/functions.php $time %= $mod; is line 5269. Can you confirm?

[TheWitness]

I did another update following your back-trace and not the line numbers since they don't even match on the 1.2.x branch.

[densenator]

Nope. I changed this to $time = floor($mod);
and it is solved my errors.
That's right?

[TheWitness]

Well, that's one, but I also looked at the backtrace and what is happening is that the hosts sysUptimeInstance was being divided by 100, which is proper, and that converted the "time" value that was sent to the next function was a float, which having a modulus on a float could also throw the loss of precision error. So, I converted it to an integer (I think). You need to make the next update and see if the backtraces go away.

[TheWitness]

I may have to add use intval() instead of floor() or round(). You need to continue to test. I don't have a PHP8.1 env at the moment.

[TheWitness]

Let's not mess with tickets. I'm only caring about 1.2.x in this ticket.