Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using cookie authentication, Same Site support does not always work properly #4612

Closed
TheWitness opened this issue Mar 12, 2022 · 0 comments
Closed

When using cookie authentication, Same Site support does not always work properly #4612

TheWitness opened this issue Mar 12, 2022 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.20

Comments

@TheWitness
Copy link
Member

Describe the bug

Noticed in Firefox that the cacti_remembers cookie is being rejected due to a missing 'secure' attribute. Upon inspection of the code, noted that it was not being set.

Expected behavior

More secure cookies.
@TheWitness TheWitness added the bug Undesired behaviour label Mar 12, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Mar 12, 2022
@TheWitness TheWitness changed the title Cacti's cacti_remembers Cookie does not include the secure or required for Same Site support Cacti's cacti_remembers Cookie does not include the secure attribute required for Same Site support Mar 12, 2022
TheWitness added a commit that referenced this issue Mar 12, 2022
@TheWitness
Fixing Issue #4612 - SameSite Secure Issue
3829317 
Cacti's cacti_remembers Cookie does not include the secure attribute required for Same Site support
@TheWitness TheWitness added the resolved A fixed issue label Mar 12, 2022
@netniV netniV changed the title Cacti's cacti_remembers Cookie does not include the secure attribute required for Same Site support When using cookie authentication, Same Site support does not always work properly Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.20
Development

No branches or pull requests
1 participant
@TheWitness