Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hooks during polling loop or at poller end #4614

Closed
TheWitness opened this issue Mar 13, 2022 · 0 comments
Closed

Add support for hooks during polling loop or at poller end #4614

TheWitness opened this issue Mar 13, 2022 · 0 comments
Labels
bug Undesired behaviour design Design issue that blocks resolution enhancement General tag for an enhancement resolved A fixed issue
Milestone
v1.2.20

Comments

@TheWitness
Copy link
Member

Describe the bug

Cacti has a feature called "remote_collect". However, that feature wan not differentiate between a hook that should function in the main poller loop and something that should execute at the poller bottom. As a result, a remote plugin that wishes to run remotely, has not way to either run in the main loop or at the end of processing.

For example, thold always needs to run in the main loop, but should not run at poller bottom. Other plugin may wish to not run in the main loop, but instead run on the poller bottom.

Expected behavior

Allow plugins to to define how they should run remotely more clearly.
@TheWitness TheWitness added bug Undesired behaviour enhancement General tag for an enhancement design Design issue that blocks resolution labels Mar 13, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Mar 13, 2022
TheWitness added a commit that referenced this issue Mar 13, 2022
@TheWitness
Fixing Issue #4614
3ac42eb 
- Cacti can not differentiate between execution remotely between the main poller loop vs. poller bottom
- Also QA including, better logging
- One Hooks in wrong section 'cacti_stats_update'
- I've noticed two hooks that are no longer in Cacti.  Need to see when they were removed 'poller_output' and 'poller_command_args'.
@TheWitness TheWitness added the resolved A fixed issue label Mar 13, 2022
TheWitness added a commit that referenced this issue Mar 14, 2022
@TheWitness
QA: Per comments on #4614
bcddab8 
- Relocating the $plugin parameter to the end
- Adding a warning if someone is using it externally
@netniV netniV changed the title Cacti can not differentiate between execution remotely between the main poller loop vs. poller bottom Add support for hooks during polling loop or at poller end Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour design Design issue that blocks resolution enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Milestone
v1.2.20
Development

No branches or pull requests
1 participant
@TheWitness