Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When removing a plugin, removed tables are not removed from remote pollers #4617

Closed
TheWitness opened this issue Mar 13, 2022 · 0 comments
Closed

When removing a plugin, removed tables are not removed from remote pollers #4617

TheWitness opened this issue Mar 13, 2022 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.20

Comments

@TheWitness
Copy link
Member

Describe the bug

When uninstalling a plugin, if there are tables created on the Remote Data collector, cacti does not take care to remove those plugin tables thus causing the plugin tables to remain.

This issue can not be solved at one time as many Cacti plugins simply perform a db_execute('DROP TABLE blah');. So, this issue must be fully corrected through the incorporation of a plugin function for people who do not use the standard table creation API, plus augmenting the plugin api to remove remote tables.

Expected behavior

More consistent behavior of the plugin API.
@TheWitness TheWitness added the bug Undesired behaviour label Mar 13, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Mar 13, 2022
TheWitness added a commit that referenced this issue Mar 13, 2022
@TheWitness
Fixing Issue #4617
b561568 
Dropping remote tables not supported in plugin API
@TheWitness TheWitness added the resolved A fixed issue label Mar 13, 2022
@netniV netniV changed the title When uninstalling a plugin, tables that are removed from plugins should be removed from remotes if replicated When removing a plugin, removed tables are not removed from remote pollers Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.20
Development

No branches or pull requests
1 participant
@TheWitness