Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using CLI, Remote Data Collector scripts may connect to the wrong database #4620

Closed
TheWitness opened this issue Mar 14, 2022 · 0 comments
Closed

When using CLI, Remote Data Collector scripts may connect to the wrong database #4620

TheWitness opened this issue Mar 14, 2022 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.20

Comments

@TheWitness
Copy link
Member

Describe the bug

In testing, I have found that when using CLI script on the Remote Data Collectors in 1.2.19, the script only connect to the local database, which is a good thing with some CLI script, but not all. This behavior needs to be changed for the release.

  • In many scripts to connect to the main collector when online, and fail if the main data collector is offline.
  • For other scripts, there should be an option of running local, for scripts like database_repair.php and analyze_database.php, and convert_tables.php.

Expected behavior

More consistent behavior in scripts.
@TheWitness TheWitness added the bug Undesired behaviour label Mar 14, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Mar 14, 2022
TheWitness added a commit that referenced this issue Mar 15, 2022
@TheWitness
Fixing Issue #4620 - Remote CLI Issues
786c069 
- Remote Data Collector CLI scripts connect to the local database instead of the main database even when online
- Add PHP Doc style documentation to lib/database.php
- Add missing $log and $db_conn to one function
@TheWitness TheWitness added the resolved A fixed issue label Mar 15, 2022
@netniV netniV changed the title Remote Data Collector CLI scripts connect to the local database instead of the main database even when online When using CLI, Remote Data Collector scripts may connect to the wrong database Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.20
Development

No branches or pull requests
1 participant
@TheWitness