Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a Data Source Profile, allow additional choices for Heartbeat #4631

Closed
riversdev0 opened this issue Mar 16, 2022 · 5 comments
Closed
Labels
enhancement General tag for an enhancement resolved A fixed issue
Milestone

Comments

@riversdev0
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe

Consider for a moment that you're using Cacti's out-of-the-box functionality to graph ping latency. To that aim, let's assume you create a Data Source Profile where the PDP (or step) should be 1 minute. Furthermore, let's assume that your polling interval is set to 1 minute and that you wish for gaps to appear in the graph on every polling interval where the data is Unknown, that is to say you don't wish for RRDTool to natively fill in Unknowns; you'd rather see a gap). Now, let's assume that your poller runs on a machine where the cron is slightly delayed by other processes (or, perhaps, where you have tons of far-away devices and the Polling Time of the Data Collector varies).

In the above scenario, when data is inserted into the RRD within 60 seconds, everything works great. But in situations where data is inserted at 61 seconds since the last data, the result is a gap in the graph despite all systems functioning properly. This undesirable trait would persuade the Cacti admin/user to change the Heartbeat to the next higher interval, which is 2 minutes. But, then, if the poller is running efficiently at exactly 60 seconds, and the poller inserts an Unknown in at 60 seconds (because the ping timed out), and subsequently a valid value 60 seconds after that, a gap will not appear in the graph because it was filled in by RRDTool's native capabilities. Thus, the actual failure of the ping will be masked by the native functionality of RRDTool.

Therefore, it seems impossible to build a configuration where gaps are not filled in, yet still avoiding gaps when the poller is 1 second late upon inserting.

Describe the solution you'd like

In light of the above situation, I propose that some additional values be added for Heartbeat. I think some proper values could be identified by adding [step interval] / 2 to some existing options. As a prime example, I would suggest 90 seconds as a valid choice for Heartbeat. Also, perhaps 330 seconds, which is 5-and-one-half polling intervals.

Describe alternatives you've considered

I modified Cacti's database directly to achieve a Heartbeat of 90 seconds. In this situation, the GUI does not understand the value of 90 and does not convert it to a friendly display of 90 Seconds.

Additional context

No additional context.

@riversdev0 riversdev0 added the enhancement General tag for an enhancement label Mar 16, 2022
@TheWitness
Copy link
Member

Okay, instead of a long description, just provide a list of I want them heartbeats.

@riversdev0
Copy link
Contributor Author

Okay, I wrote that long description because I expected some pushback.

Based upon existing choices for Poller Interval, I would suggest these added heartbeat choices:
45 Seconds
90 Seconds
330 Seconds

@TheWitness
Copy link
Member

So, on this issue, I don't think you will see much push back. It's a minor thing and does not break functionality. There may be some that wonder why "5.5 Minutes" is on the drop-down though.

@TheWitness TheWitness added this to the v1.2.20 milestone Mar 17, 2022
@TheWitness TheWitness added the resolved A fixed issue label Mar 17, 2022
TheWitness added a commit that referenced this issue Mar 17, 2022
Additional choices for Heartbeat when creating a Data Source Profile
@TheWitness
Copy link
Member

Done.

@riversdev0
Copy link
Contributor Author

Fantastic, thanks so much!

@netniV netniV changed the title Additional choices for Heartbeat when creating a Data Source Profile When creating a Data Source Profile, allow additional choices for Heartbeat Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants