When creating a Datasource, Input Field Checking is not always enforced

[riversdev0]

Describe the bug

If you have a custom field attached to a Data Input Method, that field will only be validated for acceptable data upon being edited, not upon creation.

To Reproduce

Steps to reproduce the behavior:

1. Create a Data Input Method with a custom Input Field
   

2. Set a Regular Expression Match on the Input Field
   

3. Create a Data Source Template that allows the user to modify the value of Input Field
   

4. Create a Graph Template referencing that Data Source Template

5. Add a graph using that template to a device. Set the Custom Data to something outside the range of the validation pattern.
   

6. Edit the brand new Data Source and observe that the value is out of range.
   

7. Save the Data Source with no changes. Observe that the validation fails.
   

Expected behavior

I would expect the Input Field Checking validation pattern to be enforced upon creation of the Data Source, just as it is during the modification of the Data Source.

Version info

• Cacti 1.2.19

Additional context

I'm willing to help fix this, but some others probably know from memory where the relevant code is located.

[TheWitness]

Never used that feature, though I can see why it's handy.

[TheWitness]

So, question, I'm assuming you are manually creating the data source rather than doing so using the template engine. Is this a correct assumption?

[riversdev0]

The way I'm creating the graph is by navigating to the Device, and clicking "*Create Graphs for this Device" and picking the Graph Template from the drop down. This method was used to produce the screenshots above.

I do have a point of confusion, however, about how the process described in the sentence above is different than picking the Graph Template directly from the Device page, without first clicking "*Create Graphs for this Device". Here's a screenshot of what I'm referring to, "directly on the Device page".

My confusion is that if I add the graph directly from the Device page, Cacti "remembers" the graph being there, as illustrated in this screenshot:

Yet, if I create the graph from the "*Create Graphs for this Device" page, cacti doesn't display any evidence that the device has the graph (except it does appear on the "Graphs" page, and it does fully work, there is just no evidence on the Device page).

[TheWitness]

The process is somewhat confusing, but glad you clarified.

[TheWitness]

You will have to force load your pages include/layout.js, but after which, you should be able to test this.

[TheWitness]

@riversdev0, just checking in to see if you are satisfied with the fix...

[riversdev0]

Sorry for the slow response. I've been having issues getting it to work correctly, but it might be my fault. I integrated the changes into my prod Cacti installation and here's what it does:

When creating a new graph, I enter an invalid value in the field and click "Create". The page goes blank white and does nothing. I click on some other navigation item, and I get a pop-up that says "Save Failed due to field input errors (Check red fields)" overlaid on the unrelated page to which I navigated. I can view other unrelated pages and then circle back to creating the same graph again. When I attempt to create the graph a second time, when it displays the fields again, the field into which I typed the invalid value is now highlighted red, but it contains the default value, not my invalid value.

I can clone the development branch onto a dev server and see if the issues happens there. Would you like me to test that?

[TheWitness]

You need to force reload the new layout. Browsers like chrome make it hard without clearing your cache.

[riversdev0]

Ok, I tried it in a Private browser window and I was able to see the error message, and was able to correct the value, and the new graph was created. I think the change worked as expected! Thank you!