Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date calculation support for PHP 8 #4666

Closed
TheWitness opened this issue Apr 4, 2022 · 1 comment
Closed

Add date calculation support for PHP 8 #4666

TheWitness opened this issue Apr 4, 2022 · 1 comment
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.20

Comments

@TheWitness
Copy link
Member

Describe the bug

Stricter typing in PHP 8.1.2 generates warnings when using floats on functions that require an integer. In the past, these conversions happened silently, but in PHP 8.1.2 they generate an error. In PHP 8.1.2, the Cacti get_daysfromtime() generates such warnings.

Expected behavior

Less warnings in Cacti
@TheWitness TheWitness added the bug Undesired behaviour label Apr 4, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Apr 4, 2022
@TheWitness
Copy link
Member Author

Commit is here: 44bf278

@TheWitness TheWitness mentioned this issue Apr 4, 2022
Merged
@TheWitness TheWitness added the resolved A fixed issue label Apr 4, 2022
@netniV netniV changed the title Work around stricter typing in PHP 8.1.2 when performing some date calculations Add date calculation support for PHP 8 Apr 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.20
Development

No branches or pull requests
1 participant
@TheWitness