Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Import generates errors when you try to import directory or non-file #4689

Closed
densenator opened this issue Apr 9, 2022 · 3 comments
Closed

Package Import generates errors when you try to import directory or non-file #4689

densenator opened this issue Apr 9, 2022 · 3 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
v1.2.21

Comments

@densenator
Copy link

Describe the bug

09.Apr.2022 12:06:59 - IMPORT FATAL: Unable to read Cacti Package compress.zlib:///var/www/html/cacti/plugins/mikrotik/templates/

09.Apr.2022 12:06:59 - CMDPHP PHP ERROR NOTICE Backtrace: (/cli/import_package.php[133]:fread(), CactiErrorHandler())
09.Apr.2022 12:06:59 - ERROR PHP NOTICE: fread(): read of 8192 bytes failed with errno=21 Is a directory in file: /var/www/html/cacti/cli/import_package.php on line: 133

## To Reproduce

Steps to reproduce the behavior:

  1. Use cli script for import template
  2. Choose wrong file
  3. See error
@densenator densenator added bug Undesired behaviour unverified Some days we don't have a clue labels Apr 9, 2022
@TheWitness TheWitness removed the unverified Some days we don't have a clue label Apr 9, 2022
@TheWitness TheWitness added this to the v1.2.21 milestone Apr 9, 2022
@TheWitness
Copy link
Member

This should be fixed pretty soon. Just waiting on a code review.

TheWitness added a commit that referenced this issue Apr 12, 2022
@TheWitness
Fixing Issue #4689 - Package Import Errors
5000659 
Package Import generates errors when you try to import directory or non-file
@TheWitness TheWitness changed the title CMDPHP PHP ERROR NOTICE Backtrace Package Import generates errors when you try to import directory or non-file Apr 12, 2022
@TheWitness TheWitness added the resolved A fixed issue label Apr 12, 2022
@TheWitness
Copy link
Member

Pull down a fresh copy of import_package.php and see if you can break it now.

@TheWitness TheWitness added the confirmed Bug is confirm by dev team label Apr 12, 2022
@densenator
Copy link
Author

resolved

@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
v1.2.21
Development

No branches or pull requests
2 participants
@TheWitness @densenator