Editing a new user or user group may cause errors

[paulgevers]

Describe the bug

With some minor modifications (password, more tests, see Debian patch) I run the tests/tools/check_all_pages.sh test. I changed one output and added one (will file an MR tomorrow), but then I still get errors.

ERROR: Fail - Unexpected output in /usr/share/cacti/site/log/cacti.log:
2022-04-12 20:14:57 - ERROR PHP WARNING: Undefined variable $group in file: /usr/share/cacti/site/user_group_admin.php  on line: 1769
2022-04-12 20:14:57 - CMDPHP PHP ERROR WARNING Backtrace:  (/user_group_admin.php[165]:group_edit(), /user_group_admin.php[1769]:CactiErrorHandler())
2022-04-12 20:14:57 - ERROR PHP WARNING: Trying to access array offset on value of type null in file: /usr/share/cacti/site/user_group_admin.php  on line: 1769
2022-04-12 20:14:57 - CMDPHP PHP ERROR WARNING Backtrace:  (/user_group_admin.php[165]:group_edit(), /user_group_admin.php[1769]:CactiErrorHandler())

Expected behavior

Test passes.

Desktop (please complete the following information)

• OS: Debian

• Browser: wget

• Version:

Additional context

I judged this to not be Debian specific, but if so just tell me and close the bug.

[TheWitness]

Thanks for the ticket Paul. We need travis back or to move to Github Actions here. We modified your check all pages to work with Travis, and then they cut off access even though we were in the OSS contingent.

[TheWitness]

@paulgevers, should be fixed now. Please retest.

[paulgevers]

Commit 8f0b55e fixed the issue for me.

(Had a bit of trouble finding it because its message mentions a different bug number).

[TheWitness]

Yea, sorry, I seem to be rushing this a bit. Summer is getting closer and I'm itching to get out on the bike.