Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When no guest template is set, login cookies are not properly set #4814

Closed
netniV opened this issue Jun 9, 2022 · 0 comments
Closed

When no guest template is set, login cookies are not properly set #4814

netniV opened this issue Jun 9, 2022 · 0 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone

Comments

@netniV
Copy link
Member

netniV commented Jun 9, 2022

Describe the bug

When you log into the system and attempt to set the 'remember me' option, this does not appear to be set. After a lot of diagnosis, this turns out to be because the guest account is set to none, causing the get_guest_account() function to return 0. Comparing a username with 0 apparently results in a true result ('user' == 0 is apparently true!).

To Reproduce

Steps to reproduce the behavior:

  1. Goto settings, authentication, set the guest account to none
  2. Attempt to use the remember me functionality

Expected behavior

Changing the response to be blank does fix the issue but other functions are expecting a numeric value, so should check from a strict comparison ('user' === 0 would be false, as would false === 0 be false).

Some code is mismatching usernames against id's though and needs fixing.

Screenshots

image

@netniV netniV added bug Undesired behaviour unverified Some days we don't have a clue labels Jun 9, 2022
@netniV netniV added this to the v1.2.22 milestone Jun 12, 2022
@TheWitness TheWitness added resolved A fixed issue confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Jun 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants