Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When importing, make it possible to only import certain components #4820

Closed
TheWitness opened this issue Jun 11, 2022 · 4 comments
Closed

When importing, make it possible to only import certain components #4820

TheWitness opened this issue Jun 11, 2022 · 4 comments
Assignees
@TheWitness
Labels
enhancement General tag for an enhancement resolved A fixed issue
Milestone
v1.2.23

Comments

@TheWitness
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe

It is not possible to selectively import Cacti Template components

Describe the solution you'd like

Provide the ability for a plugin author to be able to selectively import certain components from a package. This might include Graph Templates, Data Queries, Data Sources, etc.

Describe alternatives you've considered

N/A

Additional context

Required for the public release of the Packaging Plugin
@TheWitness TheWitness added the enhancement General tag for an enhancement label Jun 11, 2022
@TheWitness TheWitness added this to the v1.2.22 milestone Jun 11, 2022
TheWitness added a commit that referenced this issue Jun 11, 2022
@TheWitness
Fixing Issue #4820 - Selective Import Feature
eb8de78 
- Make it possible to only import certain components when importing packages
- This change is a pre-requisite for the upcoming Package plugin
@TheWitness TheWitness self-assigned this Jun 11, 2022
@TheWitness TheWitness added the resolved A fixed issue label Jun 11, 2022
@TheWitness
Copy link
Member Author

Going to keep this open until I can fully test out the plugin. In theory this is enough.

@netniV
Copy link
Member

netniV commented Jun 13, 2022

My only concern would be someone not realising what they are doing and wondering why a template breaks because of a partial import, but I can see the benefits too.

@TheWitness
Copy link
Member Author

Once I complete the package plugin, you will be able to see how this will work. You are right though, there might be some unintended consequences, but not for the trained eye. Anyway, more to follow.

@TheWitness TheWitness removed the resolved A fixed issue label Jun 24, 2022
@TheWitness
Copy link
Member Author

Taking off resolved until QA is complete

@netniV netniV changed the title Make it possible to only import certain components when importing packages When importing, make it possible to only import certain components Aug 14, 2022
@TheWitness TheWitness modified the milestones: v1.2.22, v1.2.23 Aug 19, 2022
TheWitness added a commit that referenced this issue Sep 18, 2022
@TheWitness
More changes to support #4820
6e6a8a9 
Add support for package import from third part packages, also add the following import overrides when done through the GUI:

* image_format
* graph_width
* graph_height
TheWitness added a commit that referenced this issue Oct 9, 2022
@TheWitness
Fixing Issue #4820 - Selective iimport
4fb20aa 
When importing, make it possible to only import certain components
@TheWitness TheWitness added the resolved A fixed issue label Oct 9, 2022
TheWitness added a commit that referenced this issue Oct 10, 2022
@TheWitness
QA on #4820 - Add more messages and show dependencies
f6a123d
TheWitness added a commit that referenced this issue Oct 10, 2022
@TheWitness
Additional QA on #4820
4daa800 
Differences and orphans not rendering correctly.
TheWitness added a commit that referenced this issue Oct 10, 2022
@TheWitness
Additional QA on #4820
6176e36 
One small typo
This was referenced Oct 17, 2022
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheWitness TheWitness

Labels
enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Milestone
v1.2.23
Development

No branches or pull requests
2 participants
@TheWitness @netniV