Skip to content

Update code style to support PHP 8 requirements #4866

Closed

Description

@v0vas

Hi mates!
Cacti 1.2.21
PHP - 8.2

I have error messages in logs:

19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_maintenance.php[26]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())

19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_maintenance.php[26]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_spikekill.php[26]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_spikekill.php[26]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_automation.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_automation.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_dsstats.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_dsstats.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_reports.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_reports.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:01 - CMDPHP PHP ERROR Backtrace: (/cmd.php[365]:ping_and_reindex_check(), /cmd.php[742]:update_system_mibs(), /cmd.php[580]:open_snmp_session(), /cmd.php[543]:cacti_snmp_session(), /lib/snmp.php[87]:CactiErrorHandler())
19.07.2022 09:59:01 - ERROR PHP DEPRECATED: Creation of dynamic property phpsnmp\SNMP::$bulk_walk_size is deprecated in file: /usr/local/share/cacti/lib/snmp.php on line: 87
19.07.2022 09:59:00 - CMDPHP PHP ERROR Backtrace: (/cmd.php[365]:ping_and_reindex_check(), /cmd.php[722]:Net_Ping->__construct(), /lib/ping.php[43]:CactiErrorHandler())
19.07.2022 09:59:00 - ERROR PHP DEPRECATED: Creation of dynamic property Net_Ping::$port is deprecated in file: /usr/local/share/cacti/lib/ping.php on line: 43
19.07.2022 09:59:00 - CMDPHP PHP ERROR Backtrace: (/script_server.php[33]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:00 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:00 - CMDPHP PHP ERROR Backtrace: (/script_server.php[33]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:00 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353

Activity

  1. added
    bugUndesired behaviour
    unverifiedSome days we don't have a clue
    on Jul 19, 2022
  2. TheWitness commented on Jul 19, 2022

    @TheWitness
    Member

    I would say Ode to a Grecian Urn (a way of saying $@^#!) on this one. Dog gammit on PHP for changing the rules.

  3. added a commit that references this issue on Jul 20, 2022
  4. added
    confirmedBug is confirm by dev team
    and removed
    unverifiedSome days we don't have a clue
    on Jul 20, 2022
  5. added this to the v1.2.22 milestone on Jul 20, 2022
  6. TheWitness commented on Jul 20, 2022

    @TheWitness
    Member

    I've made the changes to mask those Deprecation warnings. Keep testing. I know that there are a few plugins impacted, but that's secondary.

  7. added a commit that references this issue on Jul 20, 2022
  8. changed the title [-]Using ${var} in strings is deprecated, use {$var} instead in file[/-] [+]Update code style to support PHP 8 requirements[/+] on Aug 14, 2022
  9. locked and limited conversation to collaborators on Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugUndesired behaviourconfirmedBug is confirm by dev teamresolvedA fixed issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions