Skip to content

Update code style to support PHP 8 requirements #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
v0vas opened this issue Jul 19, 2022 · 2 comments
Closed

Update code style to support PHP 8 requirements #4866

v0vas opened this issue Jul 19, 2022 · 2 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
v1.2.22

Comments

@v0vas
Copy link

v0vas commented Jul 19, 2022

Hi mates!
Cacti 1.2.21
PHP - 8.2

I have error messages in logs:

19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_maintenance.php[26]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())

19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_maintenance.php[26]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_spikekill.php[26]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_spikekill.php[26]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_automation.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_automation.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_dsstats.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_dsstats.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_reports.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:02 - CMDPHP PHP ERROR Backtrace: (/poller_reports.php[34]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:02 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
19.07.2022 09:59:01 - CMDPHP PHP ERROR Backtrace: (/cmd.php[365]:ping_and_reindex_check(), /cmd.php[742]:update_system_mibs(), /cmd.php[580]:open_snmp_session(), /cmd.php[543]:cacti_snmp_session(), /lib/snmp.php[87]:CactiErrorHandler())
19.07.2022 09:59:01 - ERROR PHP DEPRECATED: Creation of dynamic property phpsnmp\SNMP::$bulk_walk_size is deprecated in file: /usr/local/share/cacti/lib/snmp.php on line: 87
19.07.2022 09:59:00 - CMDPHP PHP ERROR Backtrace: (/cmd.php[365]:ping_and_reindex_check(), /cmd.php[722]:Net_Ping->__construct(), /lib/ping.php[43]:CactiErrorHandler())
19.07.2022 09:59:00 - ERROR PHP DEPRECATED: Creation of dynamic property Net_Ping::$port is deprecated in file: /usr/local/share/cacti/lib/ping.php on line: 43
19.07.2022 09:59:00 - CMDPHP PHP ERROR Backtrace: (/script_server.php[33]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:00 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 355
19.07.2022 09:59:00 - CMDPHP PHP ERROR Backtrace: (/script_server.php[33]:require(), /include/cli_check.php[45]:include(), /include/global.php[520]:include_once(), /include/global.php[520]:CactiErrorHandler())
19.07.2022 09:59:00 - ERROR PHP DEPRECATED: Using ${var} in strings is deprecated, use {$var} instead in file: /usr/local/share/cacti/lib/html_form.php on line: 353
@v0vas v0vas added bug Undesired behaviour unverified Some days we don't have a clue labels Jul 19, 2022
@TheWitness
Copy link
Member

I would say Ode to a Grecian Urn (a way of saying $@^#!) on this one. Dog gammit on PHP for changing the rules.

TheWitness added a commit that referenced this issue Jul 20, 2022
@TheWitness
Fixing #4866 - PHP 8.2 Support
aaa502f 
Using ${var} in strings is deprecated, use {$var} instead in file
@TheWitness TheWitness added resolved A fixed issue confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Jul 20, 2022
@TheWitness TheWitness added this to the v1.2.22 milestone Jul 20, 2022
@TheWitness
Copy link
Member

I've made the changes to mask those Deprecation warnings. Keep testing. I know that there are a few plugins impacted, but that's secondary.

TheWitness added a commit that referenced this issue Jul 20, 2022
@TheWitness
Additional changes for #4866 - PHP 8.2 Deprecation warnings
8179c30
@netniV netniV changed the title Using ${var} in strings is deprecated, use {$var} instead in file Update code style to support PHP 8 requirements Aug 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
v1.2.22
Development

No branches or pull requests
2 participants
@TheWitness @v0vas