Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Business Hours #4874

Closed
thurban opened this issue Jul 23, 2022 · 6 comments
Closed

Add support for Business Hours #4874

thurban opened this issue Jul 23, 2022 · 6 comments
Labels
enhancement General tag for an enhancement resolved A fixed issue
Milestone

Comments

@thurban
Copy link
Contributor

thurban commented Jul 23, 2022

Feature Request

Is your feature request related to a problem? Please describe

Displaying Business Hours on the graph helps identifying issues during these and ignore known spikes out of office hours.

Describe the solution you'd like

Include business hours to be displayed as an AREA within the charts

Describe alternatives you've considered

There are non

Additional context

See attached early alpha for showing business hours, realized as a plugin
BusinesHours_demo_plugin_1
BusinesHours_demo_plugin_2

@thurban thurban added the enhancement General tag for an enhancement label Jul 23, 2022
@netniV
Copy link
Member

netniV commented Jul 25, 2022

Is this something you are working on @thurban ? Or just something you'd like us to add?

@thurban
Copy link
Contributor Author

thurban commented Jul 25, 2022

Hi. Im working on it. Got some basic version already working.

I probably add some basic functionality for future versions and a plugin for complete version 1.x compatibility.

@netniV
Copy link
Member

netniV commented Jul 26, 2022

Sounds good, I have places I can test it out if you need.

@TheWitness
Copy link
Member

Yea, glad to have you on board Thomas. I would like to assign this ticket to you. What do you think @netniV?

@thurban
Copy link
Contributor Author

thurban commented Jul 26, 2022

I'm going to review the code and may change it. Although it is working, it will create quite large rrdtool command line, so going to optimize that.

Maybe some special generic cdefs like from this post will make it essier:
https://forums.cacti.net/viewtopic.php?t=30839

@thurban
Copy link
Contributor Author

thurban commented Jul 27, 2022

I added a limit to display the business hours for a maximum number of days. Otherwise the rrdtool command line size may be getting too large (i.e. for year graphs)

@TheWitness TheWitness added this to the v1.2.23 milestone Aug 9, 2022
@TheWitness TheWitness added the resolved A fixed issue label Aug 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants