Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase host query performance by removing check for NULL #4889

Closed
TheWitness opened this issue Aug 12, 2022 · 0 comments
Closed

Increase host query performance by removing check for NULL #4889

TheWitness opened this issue Aug 12, 2022 · 0 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
v1.2.23

Comments

@TheWitness
Copy link
Member

Describe the bug

Due to upgrade issues over the last few releases, the SQL WHERE clauses had to be made more complicated to address both NULL and empty string issues. Post the release of 1.2.22, we can remove that compounding query logic that may lead to longer than expected query times.

Expected behavior

Better performing Cacti
@TheWitness TheWitness added bug Undesired behaviour confirmed Bug is confirm by dev team labels Aug 12, 2022
@TheWitness TheWitness added this to the v1.2.23 milestone Aug 12, 2022
TheWitness added a commit that referenced this issue Aug 19, 2022
@TheWitness
Fixing #4889 - Device Query performance
6611d21 
Increase host query performance by removing check for NULL after 1.2.22
@TheWitness TheWitness added the resolved A fixed issue label Aug 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
@netniV netniV changed the title Increase host query performance by removing check for NULL after 1.2.22 Increase host query performance by removing check for NULL Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
v1.2.23
Development

No branches or pull requests
1 participant
@TheWitness