Skip to content

Make the script server accept arguments in the standard way #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheWitness opened this issue Aug 21, 2022 · 0 comments
Closed

Make the script server accept arguments in the standard way #4901

TheWitness opened this issue Aug 21, 2022 · 0 comments
Labels
enhancement General tag for an enhancement resolved A fixed issue
Milestone
v1.2.23

Comments

@TheWitness
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe

For years, the script server has relied on positional arguments, which introduces many issues when attempting to enhance it's functionality.

Describe the solution you'd like

Have the script server

  • Provide a help function
  • Properly use the getopt function to handle arguments
  • Do this in a backward compatible way to prevent issues with partial upgrades
@TheWitness TheWitness added the enhancement General tag for an enhancement label Aug 21, 2022
@TheWitness TheWitness added this to the v1.2.23 milestone Aug 21, 2022
TheWitness added a commit that referenced this issue Aug 21, 2022
@TheWitness
Fixing #4899 and #4901 - Script Server and Poller Offline Mode
a7aa8cb 
* feature#4899: Pass poller status to script_server to avoid connecting to the main database when offline or in recovery
* feature#4901: Make the script server accept arguments in the standard way
* force error reporting off to prevent issues with output processing
@TheWitness TheWitness added the resolved A fixed issue label Aug 21, 2022
TheWitness added a commit that referenced this issue Aug 21, 2022
@TheWitness
QA on #4899, #4901
c626fcb 
Some function calls have to come later.
TheWitness added a commit that referenced this issue Aug 21, 2022
@TheWitness
QA on #4899 and #4901. --version and --help broken
02a9263
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Milestone
v1.2.23
Development

No branches or pull requests
1 participant
@TheWitness